After methods should be skipped when exclusion used #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
4 tasks
krmahadevan
force-pushed
the
krmahadevan-fix-1574
branch
from
de2936f
to
d472bc9
Compare
juherr
reviewed
Oct 15, 2017
| @@ -275,6 +275,10 @@ private static boolean isIncluded(Collection<String> includedGroups, boolean noG | |||
| } | |||
|
|
|||
| private static boolean isExcluded(Collection<String> excludedGroups, String... groups) { | |||
| boolean noGroups = (groups == null || groups.length == 0); | |||
| test.addExcludedGroup("sometest"); | ||
| TestNG testng = create(suite); | ||
| testng.run(); | ||
| assertThat(Issue1574TestclassSample.messages).containsExactly("anothertest","@AfterSuite"); |
| import java.util.List; | ||
|
|
||
| public class Issue1574TestclassSample { | ||
| public static List<String> messages = Lists.newArrayList(); |
There was a problem hiding this comment.
Prefer to use InvokedMethodNameListener when possible.
krmahadevan
force-pushed
the
krmahadevan-fix-1574
branch
from
d472bc9
to
afc8a1b
Compare
|
@juherr - I have amended the commit and fixed all the comments. Please help take a look |
|
ping @juherr - Gentle reminder.. |
juherr
reviewed
Oct 18, 2017
There was a problem hiding this comment.
The code is ok but I think it doesn't solve any issue.
@cbeust Could you check #1574 (comment)
| @@ -275,6 +275,9 @@ private static boolean isIncluded(Collection<String> includedGroups, boolean noG | |||
| } | |||
|
|
|||
| private static boolean isExcluded(Collection<String> excludedGroups, String... groups) { | |||
| if (!excludedGroups.isEmpty() && groups.length ==0) { | |||
krmahadevan
force-pushed
the
krmahadevan-fix-1574
branch
from
afc8a1b
to
ffe1505
Compare
|
ping @cbeust - Can you please help comment on this here : #1574 (comment) I would like to either close this PR if its not a bug or get this merged if its a bug. Please advise. |
krmahadevan
force-pushed
the
krmahadevan-fix-1574
branch
from
ffe1505
to
0048a83
Compare
Closes testng-team#1574 Suppose there are one or more configuration methods which don’t belong to any group and for which “alwaysRun” attribute is not set, and when the user specifies a valid exclusion list for groups, TestNG would still execute those configuration methods. Fixed this anomaly.
krmahadevan
force-pushed
the
krmahadevan-fix-1574
branch
from
0048a83
to
324bb80
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1574
Suppose there are one or more configuration methods
which don’t belong to any group and for which “alwaysRun”
attribute is not set, and when the user specifies
a valid exclusion list for groups, TestNG would still
execute those configuration methods.
Fixed this anomaly.
Fixes #1574 .
Did you remember to?
CHANGES.txtWe encourage pull requests that:
If your pull request involves fixing SonarQube issues then we would suggest that you please discuss this with the
TestNG-dev before you spend time working on it.