Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: build with .js extension and without bundling #949

Merged
merged 3 commits into from
Aug 1, 2022
Merged

Conversation

ph-fritsche
Copy link
Member

@ph-fritsche ph-fritsche commented May 10, 2022

What:

Use a different build script.

Why:

Modular build I use without problems in different libraries.
For the moment this is just to have a modular build to debug Codesandbox issues. 馃し

This seems to resolve problems with the bundled build:
Closes #839

How:

Build per ts-build2 from my personal shared-scripts config.

Checklist:

  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented May 10, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 45de469:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented May 10, 2022

Codecov Report

Merging #949 (45de469) into main (f60c89b) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #949   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         1876      1876           
  Branches       679       679           
=========================================
  Hits          1876      1876           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ph-fritsche ph-fritsche marked this pull request as ready for review August 1, 2022 11:02
@ph-fritsche ph-fritsche changed the title chore: build without bundling chore: build with .js extension and without bundling Aug 1, 2022
@ph-fritsche ph-fritsche merged commit fd8f219 into main Aug 1, 2022
@ph-fritsche ph-fritsche deleted the build branch August 1, 2022 11:11
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

馃帀 This PR is included in version 14.4.0 馃帀

The release is available on:

Your semantic-release bot 馃摝馃殌

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

_userEvent.default.setup is not a function
1 participant