Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Drop support for node 10 #698

Merged
merged 3 commits into from Oct 15, 2021
Merged

feat: Drop support for node 10 #698

merged 3 commits into from Oct 15, 2021

Conversation

nickmccurdy
Copy link
Member

@nickmccurdy nickmccurdy commented Jul 11, 2021

BREAKING CHANGE: node 10 is no longer supported. It reached its end-of-life on 30.04.2021.

What:

Closes #681

Why:

Reduces maintenance burden

How:

Change engines field to require node>=12

Checklist:

  • Tests
  • Ready to be merged

@nickmccurdy nickmccurdy added the BREAKING CHANGE This change will require a major version bump label Jul 11, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4ee01f:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Jul 11, 2021

Codecov Report

Merging #698 (d4ee01f) into userEvent14 (1bbac04) will not change coverage.
The diff coverage is n/a.

❗ Current head d4ee01f differs from pull request most recent head 32e1548. Consider uploading reports for the commit 32e1548 to get more accurate results
Impacted file tree graph

@@              Coverage Diff              @@
##           userEvent14      #698   +/-   ##
=============================================
  Coverage       100.00%   100.00%           
=============================================
  Files               50        50           
  Lines              934       934           
  Branches           368       368           
=============================================
  Hits               934       934           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1bbac04...32e1548. Read the comment docs.

@ph-fritsche ph-fritsche changed the base branch from main to userEvent14 October 15, 2021 10:19
.codesandbox/ci.json Outdated Show resolved Hide resolved
@ph-fritsche ph-fritsche merged commit f8b8a53 into userEvent14 Oct 15, 2021
@ph-fritsche ph-fritsche deleted the drop-node-10 branch October 15, 2021 10:36
ph-fritsche added a commit that referenced this pull request Oct 20, 2021
* feat: Drop support for node 10

* Update .codesandbox/ci.json

Co-authored-by: Philipp Fritsche <ph.fritsche@gmail.com>
ph-fritsche pushed a commit that referenced this pull request Oct 21, 2021
* feat: Drop support for node 10

* Update .codesandbox/ci.json

Co-authored-by: Philipp Fritsche <ph.fritsche@gmail.com>

BREAKING CHANGE: Support for node 10 was removed as it reached its end-of-life.
ph-fritsche pushed a commit that referenced this pull request Nov 28, 2021
* feat: Drop support for node 10

* Update .codesandbox/ci.json

Co-authored-by: Philipp Fritsche <ph.fritsche@gmail.com>

BREAKING CHANGE: Support for node 10 was removed as it reached its end-of-life.
@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Jan 12, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drop Node 10 support
2 participants