Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: keydownBehavior for textarea #686

Merged
merged 2 commits into from Jul 17, 2021
Merged

feat: keydownBehavior for textarea #686

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
a459753
feat: keydownBehavior for textarea
mkurcius Jun 19, 2021
41b875a
Merge branch 'master' into pr/keydown-behavior-for-textarea
ph-fritsche Jul 17, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
43 changes: 42 additions & 1 deletion src/__tests__/type.js
View file
Open in desktop
Expand Up @@ -896,7 +896,7 @@ test('should not type inside a contenteditable=false div', () => {
`)
})

test('navigation key: {arrowleft} and {arrowright} moves the cursor', () => {
test('navigation key: {arrowleft} and {arrowright} moves the cursor for <input>', () => {
const {element, getEventSnapshot} = setup('<input />')
userEvent.type(element, 'b{arrowleft}a{arrowright}c')
expect(getEventSnapshot()).toMatchInlineSnapshot(`
Expand Down Expand Up @@ -937,6 +937,47 @@ test('navigation key: {arrowleft} and {arrowright} moves the cursor', () => {
`)
})

test('navigation key: {arrowleft} and {arrowright} moves the cursor for <textarea>', () => {
const {element, getEventSnapshot} = setup('<textarea></textarea>')
userEvent.type(element, 'b{arrowleft}a{arrowright}c')
expect(getEventSnapshot()).toMatchInlineSnapshot(`
Events fired on: textarea[value="abc"]

textarea[value=""] - pointerover
textarea[value=""] - pointerenter
textarea[value=""] - mouseover: Left (0)
textarea[value=""] - mouseenter: Left (0)
textarea[value=""] - pointermove
textarea[value=""] - mousemove: Left (0)
textarea[value=""] - pointerdown
textarea[value=""] - mousedown: Left (0)
textarea[value=""] - focus
textarea[value=""] - focusin
textarea[value=""] - pointerup
textarea[value=""] - mouseup: Left (0)
textarea[value=""] - click: Left (0)
textarea[value=""] - keydown: b (98)
textarea[value=""] - keypress: b (98)
textarea[value="b"] - input
textarea[value="b"] - keyup: b (98)
textarea[value="b"] - keydown: ArrowLeft (37)
textarea[value="b"] - select
textarea[value="b"] - keyup: ArrowLeft (37)
textarea[value="b"] - keydown: a (97)
textarea[value="b"] - keypress: a (97)
textarea[value="ab"] - select
textarea[value="ab"] - input
textarea[value="ab"] - keyup: a (97)
textarea[value="ab"] - keydown: ArrowRight (39)
textarea[value="ab"] - select
textarea[value="ab"] - keyup: ArrowRight (39)
textarea[value="ab"] - keydown: c (99)
textarea[value="ab"] - keypress: c (99)
textarea[value="abc"] - input
textarea[value="abc"] - keyup: c (99)
`)
})

test('navigation key: {home} and {end} moves the cursor', () => {
const {element, getEventSnapshot} = setup('<input />')
userEvent.type(element, 'c{home}ab{end}d')
Expand Down
4 changes: 2 additions & 2 deletions src/keyboard/plugins/arrow.ts
View file
Open in desktop
Expand Up @@ -8,10 +8,10 @@ import {getSelectionRange, isElementType, setSelectionRange} from '../../utils'

export const keydownBehavior: behaviorPlugin[] = [
{
// TODO: implement for textarea and contentEditable
// TODO: implement for contentEditable
matches: (keyDef, element) =>
(keyDef.key === 'ArrowLeft' || keyDef.key === 'ArrowRight') &&
isElementType(element, 'input'),
isElementType(element, ['input', 'textarea']),
handle: (keyDef, element) => {
const {selectionStart, selectionEnd} = getSelectionRange(element)

Expand Down