Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(keyboard): fix fireInputEventIfNeeded (#583) #607

Closed
wants to merge 1 commit into from
Closed

fix(keyboard): fix fireInputEventIfNeeded (#583) #607

wants to merge 1 commit into from

Commits on Mar 22, 2021

  1. fix(keyboard): fix fireInputEventIfNeeded (#583)

    When a text input with a single character value is selected, typing text
    which starts with the same character results in the first character of
    the typed text not to be typed.
    
    This occurs as fireInputEventIfNeeded does not fire an input event due
    to the new value matching the previous value of the input. The next
    character is then typed and the selected text is then overwritten.
    
    This fix changes the fireInputEventIfNeeded condition from no event
    being fired when the previous and new values match to an event being
    fired in this scenario when the element value has a selection.
    fergusmcdonald committed Mar 22, 2021
    Configuration menu
    Copy the full SHA
    02037d4 View commit details
    Browse the repository at this point in the history