Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support empty string for maxlength #595

Merged
merged 4 commits into from
Mar 18, 2021
Merged

Support empty string for maxlength #595

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
516498c
Support empty string for maxlength
Aprillion Mar 18, 2021
3be4a2a
fix: sanitize maxLength attribute
ph-fritsche Mar 18, 2021
3bff3f5
test: mv tests
ph-fritsche Mar 18, 2021
72016b2
Merge pull request #1 from testing-library/pr-595
Aprillion Mar 18, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
38 changes: 38 additions & 0 deletions src/__tests__/type.js
View file
Open in desktop
Expand Up @@ -292,6 +292,44 @@ test('honors maxlength', () => {
`)
})

test('honors maxlength="" as if there was no maxlength', () => {
const {element, getEventSnapshot} = setup('<input maxlength="" />')
userEvent.type(element, '123')

expect(getEventSnapshot()).toMatchInlineSnapshot(`
Events fired on: input[value="123"]

input[value=""] - pointerover
input[value=""] - pointerenter
input[value=""] - mouseover: Left (0)
input[value=""] - mouseenter: Left (0)
input[value=""] - pointermove
input[value=""] - mousemove: Left (0)
input[value=""] - pointerdown
input[value=""] - mousedown: Left (0)
input[value=""] - focus
input[value=""] - focusin
input[value=""] - pointerup
input[value=""] - mouseup: Left (0)
input[value=""] - click: Left (0)
input[value=""] - keydown: 1 (49)
input[value=""] - keypress: 1 (49)
input[value="1"] - input
"{CURSOR}" -> "1{CURSOR}"
input[value="1"] - keyup: 1 (49)
input[value="1"] - keydown: 2 (50)
input[value="1"] - keypress: 2 (50)
input[value="12"] - input
"1{CURSOR}" -> "12{CURSOR}"
input[value="12"] - keyup: 2 (50)
input[value="12"] - keydown: 3 (51)
input[value="12"] - keypress: 3 (51)
input[value="123"] - input
"12{CURSOR}" -> "123{CURSOR}"
input[value="123"] - keyup: 3 (51)
`)
})

test('honors maxlength with existing text', () => {
const {element, getEventSnapshot} = setup(
'<input value="12" maxlength="2" />',
Expand Down
5 changes: 4 additions & 1 deletion src/utils/edit/calculateNewValue.ts
View file
Open in desktop
Expand Up @@ -16,7 +16,10 @@ export function calculateNewValue(

// can't use .maxLength property because of a jsdom bug:
// https://github.com/jsdom/jsdom/issues/2927
const maxLength = Number(element.getAttribute('maxlength') ?? -1)
//
// '' is a valid value in DOM with the same meaning as -1, not 0 => use ||
// eslint-disable-next-line @typescript-eslint/prefer-nullish-coalescing
const maxLength = Number(element.getAttribute('maxlength') || -1)
Aprillion marked this conversation as resolved.
Show resolved Hide resolved

let newValue: string, newSelectionStart: number

Expand Down