Implement arrow interactions as arrowPress #300
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: Add arrow interactions to the user-event API
Why: Arrow interactions emit key down event, maybe a key press event (I need help on this), and a key up event -- in that particular order. Arrow interactions are crucial in implementing accessibility support for UI widgets. However, there are more than just arrows -- we also need a HOME and END (to name a couple) keys support.
How: Adds an
arrowPress
function to the module API -- however, perhaps it makes more sense to expose these interactions as a different API (and for better long-term purposes)Checklist:
This is not ready to be merged. As I developed this, I figured I should get more feedback on the API design and testing design. I can follow up on documentation and typing -- though, I will be honest, I don't know how typing are defined in this repository -- and any additional PR checklist/revisions/what-have-yous.
Thank you for your time!