Avoid usage of logical nullish assignment for node 14 compatibility #1015
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 08dbf36:
|
| @@ -98,7 +98,7 @@ export class KeyboardHost { | |||
| const target = getActiveElementOrBody(config.document) | |||
| this.setKeydownTarget(target) | |||
|
|
|||
| this.pressed[code] ??= { | |||
| this.pressed[code] = this.pressed[code] ?? { | |||
There was a problem hiding this comment.
not sure about the eslint as that would mean if I understand correctly that the ??= is unnecessary here and we not even need a fallback?
/cc @ph-fritsche
| @@ -41,7 +41,7 @@ export class PointerHost { | |||
| private registry = {} as Record<string, Device> | |||
|
|
|||
| get(k: string) { | |||
| this.registry[k] ??= new Device() | |||
| this.registry[k] = this.registry[k] ?? new Device() | |||
|
Thanks for contributing and trying to fix this ❤️ But I'll fix it in the build script instead of the source. Otherwise the problem would just be reintroduced later. |
1 task
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Replace logical nullish assignement
test ??= otherwithtest = test ?? other.Why:
For better compatibility.
See #1014
How:
Adopting the source files.
Checklist: