Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not build in pre-commit #1008

Merged
merged 3 commits into from Aug 1, 2022
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
14 changes: 9 additions & 5 deletions .github/workflows/validate.yml → .github/workflows/ci.yml
@@ -1,4 +1,4 @@
name: validate
name: CI
on:
push:
branches:
Expand All @@ -14,7 +14,7 @@ on:
pull_request:
branches-ignore: ['all-contributors/**']
jobs:
main:
validate:
strategy:
matrix:
node: [12, 14, 16]
Expand All @@ -36,14 +36,18 @@ jobs:
env:
HUSKY_SKIP_INSTALL: true

- name: ▶️ Run validate script
run: npm run validate
- name: ✍ Lint
run: npm run lint
- name: 🧪 Test
run: npm run test -- --coverage
- name: 🏗 Build
run: npm run build

- name: ⬆️ Upload coverage report
uses: codecov/codecov-action@v1

release:
needs: main
needs: validate
runs-on: ubuntu-latest
if:
${{ github.repository == 'testing-library/user-event' &&
Expand Down
3 changes: 1 addition & 2 deletions package.json
Expand Up @@ -32,8 +32,7 @@
"test": "kcd-scripts test",
"test:debug": "kcd-scripts --inspect-brk test --runInBand",
"test:update": "npm test -- --updateSnapshot --coverage",
"validate": "kcd-scripts validate",
"typecheck": "kcd-scripts typecheck"
"validate": "kcd-scripts typecheck"
},
"devDependencies": {
"@ph.fritsche/scripts-config": "^2.2.4",
Expand Down