Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: keydownBehavior for textarea #686

Merged

Conversation

mkurcius
Copy link
Contributor

What:
added keydownBehavior for textarea

Why:
{arrowleft} and {arrowright} are not working for textarea elements

How:
added textarea to isElementType params in keydownBehavior

Checklist:

  • Documentation
  • Tests
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 19, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 41b875a:

Sandbox Source
userEvent-PR-template Configuration

@codecov
Copy link

codecov bot commented Jul 9, 2021

Codecov Report

Merging #686 (41b875a) into master (ffba2df) will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##            master      #686   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           50        50           
  Lines          934       934           
  Branches       368       368           
=========================================
  Hits           934       934           
Impacted Files Coverage Δ
src/keyboard/plugins/arrow.ts 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ffba2df...41b875a. Read the comment docs.

@ph-fritsche ph-fritsche merged commit f8f00d4 into testing-library:master Jul 17, 2021
@ph-fritsche
Copy link
Member

@all-contributors add @mkurcius code

@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @mkurcius! 🎉

@github-actions
Copy link

🎉 This PR is included in version 13.2.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

@ph-fritsche
Copy link
Member

Thanks a lot for verifying that reusing that implementation on textarea doesn't hurt 😃

@mkurcius mkurcius deleted the pr/keydown-behavior-for-textarea branch July 17, 2021 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Typing {arrowleft} doesn't change the selection {arrowleft} and {arrowright} are not working for <textarea>
2 participants