Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Drop Node 10 support #681

Closed
MichaelDeBoey opened this issue May 16, 2021 · 4 comments · Fixed by #698
Closed

Drop Node 10 support #681

MichaelDeBoey opened this issue May 16, 2021 · 4 comments · Fixed by #698
Labels
BREAKING CHANGE This change will require a major version bump
Milestone

Comments

@MichaelDeBoey
Copy link
Member

Because it's EOL.

@MichaelDeBoey MichaelDeBoey added the BREAKING CHANGE This change will require a major version bump label May 16, 2021
@ph-fritsche
Copy link
Member

Why would you consider this a breaking change?
There won't be changes in this library and I don't think we promised to support a specific Node version anywhere.
We just happen to test on all currently supported Node versions because it's a reasonable thing to do. (Didn't make a feature release when adding tests for Node16 either.) It's just noise for the library consumers.

@nickmccurdy
Copy link
Member

nickmccurdy commented Jul 11, 2021

We promise to support Node 10 in package.json:

"engines": {
  "node": ">=10"
}

If I remember correctly, Yarn fails builds on engine mismatch by default. This is therefore a breaking change for Yarn users on Node 10, and also any npm users that manually enable engine-strict.

@ph-fritsche
Copy link
Member

Would it be reasonable to remove the engines restriction and make this a fix instead of major ?
We don't rely on any of the Node APIs in this package. We even support test environments in the browser.

@nickmccurdy
Copy link
Member

nickmccurdy commented Jul 18, 2021

Would it be reasonable to remove the engines restriction and make this a fix instead of major ?

I feel like that would imply we're still supporting Node 10, which we're not really, since we already disabled it within CI in #685. Semver minor releases are supposed to be fully back compatible, so not saying we will try to support Node 10 is a breaking change, even if Node 10 still works, IMO. If you want us to continue supporting Node 10 explicitly, we could revert these PRs, but that could still prevent users from upgrading DOM Testing Library and React Testing Library.

We don't rely on any of the Node APIs in this package. We even support test environments in the browser.

True, but the Node version still affects other things we depend on such as JavaScript syntax and other feature support. Most browsers update themselves automatically so I feel like this is less of an issue with supporting browsers anyway.

Overall I think it's still a good idea for us to use engines, since it helps users understand if they're using a supported Node version and it's already something we do with DOM Testing Library and React Testing Library.

@ph-fritsche ph-fritsche added this to the userEvent v14 milestone Oct 15, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
BREAKING CHANGE This change will require a major version bump
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants