Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The upgrade from 14.3.0 to 14.4.0 of @testing-library/user-event no longer supports node 14 #1014

Closed
sesam opened this issue Aug 2, 2022 · 4 comments · Fixed by #1016
Closed

The upgrade from 14.3.0 to 14.4.0 of @testing-library/user-event no longer supports node 14 #1014

sesam opened this issue Aug 2, 2022 · 4 comments · Fixed by #1016
Labels
bug Something isn't working released

Comments

@sesam
Copy link

sesam commented Aug 2, 2022 •
edited

Reproduction example

Not a website

Prerequisites

Reproduce

  1. Run with node 14, so e.g. nvm use 14
  2. run any test that imports this library

Expected behavior

With no major version bump this package should still be possible to load.

Actual behavior

It fails, saying ??= isn't supported.

User-event version

14.4.0

Environment

Testing Library framework:

JS framework:

DOM implementation:

Additional context

Suggest to either make this a major version bump,

or look into what went wrong with the build pipeline change in this version -> fd8f219
@sesam sesam added bug Something isn't working needs assessment This needs to be looked at by a team member labels Aug 2, 2022
@ph-fritsche ph-fritsche removed the needs assessment This needs to be looked at by a team member label Aug 2, 2022
This was referenced Aug 2, 2022
Closed
Merged
@ph-fritsche ph-fritsche mentioned this issue Aug 2, 2022
Merged
1 task
@ph-fritsche
Copy link
Member

Thanks for the report. ❤️

@ph-fritsche
Copy link
Member

@all-contributors add @sesam bug

@allcontributors allcontributors bot mentioned this issue Aug 2, 2022
Merged
@allcontributors
Copy link
Contributor

@ph-fritsche

I've put up a pull request to add @sesam! 🎉

@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🎉 This issue has been resolved in version 14.4.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Something isn't working released
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(build): transpile to es2019 syntax testing-library/user-event
2 participants
@sesam @ph-fritsche