chore: do not build in pre-commit #1008
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What:
Run
typecheck
during pre-commit.Run
lint
test
andbuild
in CI.Why:
build
writes to the file system includingpackage.json
which might result in uncommitted changes.The properties set on
package.json
by the build script should not be included in the repository as this might give the false impression that changes there might have an effect on the distributed package.How:
During
pre-commit
hook thevalidate
script skipslint
andtest
and only runsbuild
andtypecheck
.We only need
typecheck
here.In CI the
validate
script runslint
,test
,build
andtypecheck
.The build already includes the typecheck.
=> The
validate
script invoked by thepre-commit
script directly callskcd-scripts typecheck
.=> The CI explicitly lists
lint
,test
andbuild
as separate steps.Checklist: