Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: do not build in pre-commit #1008

Merged
merged 3 commits into from Aug 1, 2022
Merged

chore: do not build in pre-commit #1008

merged 3 commits into from Aug 1, 2022

Conversation

ph-fritsche
Copy link
Member

What:

Run typecheck during pre-commit.

Run lint test and build in CI.

Why:

build writes to the file system including package.json which might result in uncommitted changes.
The properties set on package.json by the build script should not be included in the repository as this might give the false impression that changes there might have an effect on the distributed package.

How:

During pre-commit hook the validate script skips lint and test and only runs build and typecheck.
We only need typecheck here.

In CI the validate script runs lint, test, build and typecheck.
The build already includes the typecheck.

=> The validate script invoked by the pre-commit script directly calls kcd-scripts typecheck.
=> The CI explicitly lists lint, test and build as separate steps.

Checklist:

  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 1, 2022

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit af4d677:

Sandbox Source
userEvent-dom Configuration
userEvent-react Configuration

@codecov
Copy link

codecov bot commented Aug 1, 2022

Codecov Report

Merging #1008 (af4d677) into main (6749918) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main     #1008   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           87        87           
  Lines         1876      1876           
  Branches       679       679           
=========================================
  Hits          1876      1876           

Help us with your feedback. Take ten seconds to tell us how you rate us.

@ph-fritsche ph-fritsche merged commit 1c156c2 into main Aug 1, 2022
@ph-fritsche ph-fritsche deleted the chore-validate branch August 1, 2022 13:46
@github-actions
Copy link

github-actions bot commented Aug 2, 2022

🎉 This PR is included in version 14.4.0 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant