Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Don't test with node 10 #927

Closed
wants to merge 2 commits into from
Closed

Conversation

nickmccurdy
Copy link
Member

What: Don't test with node 10 (related to #922)

Why: Node 10 reached EOL on July 30th so let's free up some CI resources.

How: Remove 10 from node test matrix.

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 12, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 46d9203:

Sandbox Source
React Configuration
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 12, 2021

Codecov Report

Merging #927 (46d9203) into main (487eb85) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##              main      #927   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files            4         4           
  Lines          140       140           
  Branches        28        28           
=========================================
  Hits           140       140           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 487eb85...46d9203. Read the comment docs.

@nickmccurdy
Copy link
Member Author

The test failures seem to be because of the experimental React alpha updates. No additional tests are being added here anyway, so it's safe to merge.

@eps1lon eps1lon mentioned this pull request Jun 12, 2021
2 tasks
@eps1lon
Copy link
Member

eps1lon commented Jun 12, 2021

Closed in #930

@eps1lon eps1lon closed this Jun 12, 2021
@eps1lon eps1lon deleted the nickmccurdy-patch-1 branch June 23, 2021 06:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants