Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Don't mix require and import #415

Merged
merged 1 commit into from
Jul 26, 2019
Merged

Don't mix require and import #415

merged 1 commit into from
Jul 26, 2019

Conversation

jeetiss
Copy link
Contributor

@jeetiss jeetiss commented Jul 26, 2019

What:

fix #414

How:

use import instead require

Checklist:

  • Documentation added to the
    docs site
  • Tests
  • Typescript definitions updated
  • Ready to be merged

Copy link
Member

@kentcdodds kentcdodds left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@kentcdodds kentcdodds merged commit 34d69cf into testing-library:master Jul 26, 2019
kentcdodds pushed a commit that referenced this pull request Jul 26, 2019
There was an issue with a patch release, so this manual-releases.md
change is to release a new patch version.

Reference: #415
@kentcdodds
Copy link
Member

@all-contributors please add @jeetiss for code

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @jeetiss! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 8.0.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

@jeetiss jeetiss deleted the fix/browser branch July 26, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

8.0.6 release breaks test in browser
2 participants