Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support React 18 #655

Closed
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
4 changes: 3 additions & 1 deletion .github/workflows/validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -14,10 +14,12 @@ jobs:
main:
# ignore all-contributors PRs
if: ${{ !contains(github.head_ref, 'all-contributors') }}
continue-on-error: ${{ contains(matrix.react, 'next') }}
strategy:
matrix:
node: [12.13, 12, 14, 16]
react: [16.9.0, ^16, ^17]
react: [16.9.0, ^16, ^17, next]

runs-on: ubuntu-latest
steps:
- name: 🛑 Cancel Previous Runs
Expand Down
1 change: 1 addition & 0 deletions src/__tests__/resultHistory.test.ts
Original file line number Diff line number Diff line change
Expand Up @@ -23,6 +23,7 @@ describe('result history tests', () => {
rerender(2)

expect(result.error).toEqual(Error('expected'))
// double error thrown for dom, but not default or native...
expect(result.all).toEqual([0, 1, Error('expected')])

rerender(3)
Expand Down
10 changes: 5 additions & 5 deletions src/dom/pure.ts
Original file line number Diff line number Diff line change
@@ -1,32 +1,32 @@
import * as ReactDOM from 'react-dom'
import { act } from 'react-dom/test-utils'

import { RendererProps, RendererOptions } from '../types/react'

import { createRenderHook } from '../core'
import { createTestHarness } from '../helpers/createTestHarness'
import { createRoot } from '../helpers/createRoot'

function createDomRenderer<TProps, TResult>(
rendererProps: RendererProps<TProps, TResult>,
{ wrapper }: RendererOptions<TProps>
) {
const container = document.createElement('div')
const testHarness = createTestHarness(rendererProps, wrapper)

const root = createRoot(container)
return {
render(props?: TProps) {
act(() => {
ReactDOM.render(testHarness(props), container)
root.render(testHarness(props))
})
},
rerender(props?: TProps) {
act(() => {
ReactDOM.render(testHarness(props), container)
root.render(testHarness(props))
})
},
unmount() {
act(() => {
ReactDOM.unmountComponentAtNode(container)
root.unmount()
})
},
act
Expand Down
30 changes: 30 additions & 0 deletions src/helpers/createRoot.ts
Original file line number Diff line number Diff line change
@@ -0,0 +1,30 @@
import * as ReactDOM from 'react-dom'
import * as React from 'react'

/* istanbul ignore next */
function createLegacyRoot(container: Element): ReactDOM.Root {
return {
render(element: React.ReactElement) {
ReactDOM.render(element, container)
},
unmount() {
ReactDOM.unmountComponentAtNode(container)
}
}
}

/* istanbul ignore next */
export function createRoot(container: Element) {
return (ReactDOM.createRoot ? ReactDOM.createRoot : createLegacyRoot)(container)
}

/* istanbul ignore next */
export function hydrateLegacyRoot(container: Element, element: React.ReactElement): ReactDOM.Root {
ReactDOM.hydrate(element, container)
return createLegacyRoot(container)
}

/* istanbul ignore next */
export function hydrateRoot(container: Element, element: React.ReactElement) {
return (ReactDOM.hydrateRoot ? ReactDOM.hydrateRoot : hydrateLegacyRoot)(container, element)
}
28 changes: 14 additions & 14 deletions src/server/pure.ts
Original file line number Diff line number Diff line change
Expand Up @@ -6,16 +6,16 @@ import { RendererOptions, RendererProps } from '../types/react'

import { createRenderHook } from '../core'
import { createTestHarness } from '../helpers/createTestHarness'
import { hydrateRoot } from '../helpers/createRoot'

function createServerRenderer<TProps, TResult>(
rendererProps: RendererProps<TProps, TResult>,
{ wrapper }: RendererOptions<TProps>
) {
let renderProps: TProps | undefined
let container: HTMLDivElement | undefined
let serverOutput: string = ''
const testHarness = createTestHarness(rendererProps, wrapper, false)

let root: ReactDOM.Root | undefined
return {
render(props?: TProps) {
renderProps = props
Expand All @@ -28,30 +28,30 @@ function createServerRenderer<TProps, TResult>(
})
},
hydrate() {
if (container) {
if (root) {
throw new Error('The component can only be hydrated once')
} else {
container = document.createElement('div')
const container = document.createElement('div')
container.innerHTML = serverOutput
act(() => {
ReactDOM.hydrate(testHarness(renderProps), container!)
root = hydrateRoot(container, testHarness(renderProps))
})
}
},
rerender(props?: TProps) {
if (!container) {
throw new Error('You must hydrate the component before you can rerender')
}
act(() => {
ReactDOM.render(testHarness(props), container!)
if (!root) {
throw new Error('You must hydrate the component before you can rerender')
}
root.render(testHarness(props))
})
},
unmount() {
if (container) {
act(() => {
ReactDOM.unmountComponentAtNode(container!)
})
}
act(() => {
if (root) {
root.unmount()
}
})
},
act
}
Expand Down
3 changes: 2 additions & 1 deletion tsconfig.json
Original file line number Diff line number Diff line change
@@ -1,6 +1,7 @@
{
"extends": "./node_modules/kcd-scripts/shared-tsconfig.json",
"compilerOptions": {
"target": "ES6"
"target": "ES6",
"types": ["node", "jest", "react/next", "react-dom/next"]
}
}