add tests to prove jest useFakeTimers is supported #641
Conversation
Codecov Report
@@ Coverage Diff @@
## main #641 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 15 15
Lines 235 235
Branches 33 33
=========================================
Hits 235 235 Continue to review full report at Codecov.
|
|
@mpeyper Sorry I had a merge conflict and I am fixing it by creating this new pull request 😸 |
# Conflicts: # src/dom/__tests__/asyncHook.test.ts # src/native/__tests__/asyncHook.test.ts # src/server/__tests__/asyncHook.test.ts
|
I've updated the test to use the new mutil-renderer tests. I've also moved them into their own file specifically for fake timers so we can expand it further when looking closer at #631. Thanks again for the effort on this so far, and sorry it took me so long to get back to this. @all-contributors please add @chris110408 for test |
|
I've put up a pull request to add @chris110408! 🎉 |
|
🎉 This PR is included in version 7.0.2 🎉 The release is available on: Your semantic-release bot 📦🚀 |
What:
Add test to show the jest.useFakeTimers() which use with advancing the timers has been supported. However, the reason why
dom-testing-libraryimplement the feature( jest.useFakeTimers() work automagically without explicitly advancing the timers) is not clear, a further investigation may continue.Why:
related to #631,
How:
we add tests use jest.useFakeTimers() (wrap with try-catch and finally to make sure the fake timers would not break other tests when test fail,) in dom, native, and server. all test success run
Checklist: