Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Convert to TypeScript #520

Merged
merged 56 commits into from Dec 15, 2020
Merged

Convert to TypeScript #520

merged 56 commits into from Dec 15, 2020

Commits on Dec 9, 2020

  1. Added tsconfig.json. Modified eslint config

    @nobrayner
    nobrayner committed Dec 9, 2020
    Copy the full SHA
    b7c28dc View commit details
    Browse the repository at this point in the history

  2. Convert src/cleanup.js to TypeScript

    @nobrayner
    nobrayner committed Dec 9, 2020
    Copy the full SHA
    a7b9412 View commit details
    Browse the repository at this point in the history

  3. Change src/cleanup.ts to use inline types

    @nobrayner
    nobrayner committed Dec 9, 2020
    Copy the full SHA
    cdfca10 View commit details
    Browse the repository at this point in the history

  4. revert eslintrc

    @merodiro
    merodiro committed Dec 9, 2020
    Copy the full SHA
    5e5a248 View commit details
    Browse the repository at this point in the history

  5. disable eslint for cleanup import 

    this can be reverted when `pure.js` is converted to typescript
    @merodiro
    merodiro committed Dec 9, 2020
    Copy the full SHA
    07278d0 View commit details
    Browse the repository at this point in the history

  6. convert index to typescript 

    just a rename 😅
    @merodiro
    merodiro committed Dec 9, 2020
    Copy the full SHA
    e8b9dae View commit details
    Browse the repository at this point in the history

Commits on Dec 10, 2020

  1. Worked on typing asyncUtils. Removed deprecated wait. Disabled import… 

    …/no-unresolved for now
    @juhanakristian
    juhanakristian committed Dec 10, 2020
    Copy the full SHA
    bc2a6c3 View commit details
    Browse the repository at this point in the history

  2. Fix incorrect cleanup callback type

    @nobrayner
    nobrayner committed Dec 10, 2020
    Copy the full SHA
    f58e7f0 View commit details
    Browse the repository at this point in the history

  3. asyncUtils has been updated. Two lines are disabled for eslint.

    @tigerabrodi
    tigerabrodi committed Dec 10, 2020
    Copy the full SHA
    a8ece29 View commit details
    Browse the repository at this point in the history

  4. remove unnecessary eslint disable

    @merodiro
    merodiro committed Dec 10, 2020
    Copy the full SHA
    7e45893 View commit details
    Browse the repository at this point in the history

Commits on Dec 11, 2020

  1. Prettier was stripping try catch types 

    - see: https://prettier.io/blog/2020/08/24/2.1.0.html\#type-annotations-on-catch-clauses-8805httpsgithubcomprettierprettierpull8805-by-fiskerhttpsgithubcomfisker
- Updated prettier in local devDeps to resolve directly to newest supported version
    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    b8ddea3 View commit details
    Browse the repository at this point in the history

  2. Type for callback handle generic input & undefined handled by nullish… 

    … operator

TS expecting explicit return of undefined from arrow function with type
Expected to return a value at the end of arrow function.eslintconsistent-return
resolved by passing return in catch with undefined, same behavior more explicit
    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    4445273 View commit details
    Browse the repository at this point in the history

  3. comments for review

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    05e9a38 View commit details
    Browse the repository at this point in the history

  4. VoidFunction in place for void until decided behavior for waitFor()

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    6879cfd View commit details
    Browse the repository at this point in the history

  5. Utilizing OR operator with generic Types allows for desired behavior … 

    …and previous tests pass
    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    8f902ea View commit details
    Browse the repository at this point in the history

  6. mistakenly left out linter ignores in last commit

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    2c2908b View commit details
    Browse the repository at this point in the history

  7. Minimum types started for Pure file 

    - File needs better, improved typing and Refactoring for Linter Disables to be removed IF POSSIBLE
    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    58b9b37 View commit details
    Browse the repository at this point in the history

  8. removed comments -- answered in PR 

    - Types and OR check should handle expected behavior
    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    4818ced View commit details
    Browse the repository at this point in the history

  9. Generic HTML types for initialProps

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    4c8d1e2 View commit details
    Browse the repository at this point in the history

  10. Generic HTML types for initialProps

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    3f9d853 View commit details
    Browse the repository at this point in the history

  11. Generic type for callback and initialProps

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    d2dadf5 View commit details
    Browse the repository at this point in the history

  12. Generics added and CB toplevel same generic pattern added

    @JacobMGEvans
    JacobMGEvans committed Dec 11, 2020
    Copy the full SHA
    1dba932 View commit details
    Browse the repository at this point in the history

Commits on Dec 12, 2020

  1. force rebuild with unbound method eslint ignore

    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    6b19d1b View commit details
    Browse the repository at this point in the history

  2. parser issue -- attempt to fix by removing specific TS eslint rule

    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    9604dd7 View commit details
    Browse the repository at this point in the history

  3. Newer versions of ESLint might resolve the parser issue

    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    b84a0de View commit details
    Browse the repository at this point in the history

  4. Added configs to get started on test conversion

    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    319cbba View commit details
    Browse the repository at this point in the history

  5. Generic type for resultContainer 

    this should allow typescript to infer the type of result.current
further improvments needed to add type guards
    @merodiro
    merodiro committed Dec 12, 2020
    Copy the full SHA
    ec18c2a View commit details
    Browse the repository at this point in the history

  6. convert tests that require no changes 

    renamed tests that didn't require code changes to the tests
    @merodiro
    merodiro committed Dec 12, 2020
    Copy the full SHA
    7c8ddee View commit details
    Browse the repository at this point in the history

  7. add types to cleanup test

    @merodiro
    merodiro committed Dec 12, 2020
    Copy the full SHA
    e3ecb24 View commit details
    Browse the repository at this point in the history

  8. Test TS Overhaul 

    - Amr, Tiger and myself worked on these commits
- Other Raid members in chat assisted
- All tests are strongly typed with minimal types
to allow for working and made sure tests types were easily usable
with types in Pure and Utils file, allow for good UX & DX
    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    d74e947 View commit details
    Browse the repository at this point in the history

  9. Amr updated types useEffect

    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    d85fb85 View commit details
    Browse the repository at this point in the history

  10. Jens suggestion for more generic number key type

    @JacobMGEvans
    JacobMGEvans committed Dec 12, 2020
    Copy the full SHA
    ce60735 View commit details
    Browse the repository at this point in the history

  11. Remove wait reference from docs

    @nobrayner
    nobrayner committed Dec 12, 2020
    Copy the full SHA
    74793cd View commit details
    Browse the repository at this point in the history

  12. Add nobrayner to contributors

    @nobrayner
    nobrayner committed Dec 12, 2020
    Copy the full SHA
    acfed0d View commit details
    Browse the repository at this point in the history

  13. Add JacobMGEvans to contributors

    @nobrayner
    nobrayner committed Dec 12, 2020
    Copy the full SHA
    b77b17a View commit details
    Browse the repository at this point in the history

Commits on Dec 13, 2020

  1. Update src/pure.tsx

    @JacobMGEvans
    JacobMGEvans committed Dec 13, 2020
    Copy the full SHA
    b5977f6 View commit details
    Browse the repository at this point in the history

  2. Add tigerabrodi to contributors

    @nobrayner
    nobrayner committed Dec 13, 2020
    Copy the full SHA
    e6997ca View commit details
    Browse the repository at this point in the history

  3. Add Amr, Juhana, and Jens to contributors

    @nobrayner
    nobrayner committed Dec 13, 2020
    Copy the full SHA
    3485a02 View commit details
    Browse the repository at this point in the history

  4. update suspenseHook, cache type and the type of the error in catch.

    @tigerabrodi
    tigerabrodi committed Dec 13, 2020
    Copy the full SHA
    ed2bb4a View commit details
    Browse the repository at this point in the history

  5. cleanup.ts, update the way addCleanup adds another callback to cleanu… 

    …pCallbacks.
    @tigerabrodi
    tigerabrodi committed Dec 13, 2020
    Copy the full SHA
    65e4d0c View commit details
    Browse the repository at this point in the history

Commits on Dec 14, 2020

  1. Made generics more descriptive, made TestHook generic

    @nobrayner
    nobrayner committed Dec 14, 2020
    Copy the full SHA
    d51ddc1 View commit details
    Browse the repository at this point in the history

  2. Remove some eslint disables that didn't do anything

    @nobrayner
    nobrayner committed Dec 14, 2020
    Copy the full SHA
    fb93f4e View commit details
    Browse the repository at this point in the history

  3. Remove DefinitelyTyped reference in CONTRIBUTING.md

    @nobrayner
    nobrayner committed Dec 14, 2020
    Copy the full SHA
    1779a85 View commit details
    Browse the repository at this point in the history

  4. chore: disable declaration for tests

    @marcosvega91
    marcosvega91 committed Dec 14, 2020
    Copy the full SHA
    78c146e View commit details
    Browse the repository at this point in the history

  5. Removes createTimeoutError. Adds constructor to TimeoutError. Adds ty… 

    …peing to waitForValueToChange options
    @juhanakristian
    juhanakristian committed Dec 14, 2020
    Copy the full SHA
    9d957ba View commit details
    Browse the repository at this point in the history

Commits on Dec 15, 2020

  1. Remove conditional in TestHook for hookProps

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    d1c36bd View commit details
    Browse the repository at this point in the history

  2. Replace old types defs with referenced types in dependencies

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    21a1c6e View commit details
    Browse the repository at this point in the history

  3. Remove destructuring of testRenderer

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    d621cda View commit details
    Browse the repository at this point in the history

  4. Disabled floating promise lint rule globally

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    900e89c View commit details
    Browse the repository at this point in the history

  5. Refactor TestHook catch to not disable lint rules

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    4ead36f View commit details
    Browse the repository at this point in the history

  6. Disabled eslint error for while(true)

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    25509ba View commit details
    Browse the repository at this point in the history

  7. Cleaned up some line warnings from tests

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    db8a6f3 View commit details
    Browse the repository at this point in the history

  8. Added "typecheck" kcd-script to improve "validate" script

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    f0d080e View commit details
    Browse the repository at this point in the history

  9. Clean up ThrowError type in errorHook tests

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    84a40ad View commit details
    Browse the repository at this point in the history

  10. Replace VoidFunction with () => void

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    f33e457 View commit details
    Browse the repository at this point in the history

  11. Replace CallableFunction with a more explicit function type

    @mpeyper
    mpeyper committed Dec 15, 2020
    Copy the full SHA
    a5754f2 View commit details
    Browse the repository at this point in the history