Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: add js suffix to isEqualWith import #599

Merged
merged 2 commits into from
May 3, 2024

Conversation

MatanBobi
Copy link
Member

Resolves #598

YunhwanJeong added a commit to YunhwanJeong/bookstore that referenced this pull request May 3, 2024
- jest-dom v6.4.3 has esm relevant issue, so it makes the test to be failed.
- someone has already made the GitHub issue and PR to fix, so fix the version to 6.4.2 temporarily.
  - testing-library/jest-dom#599
YunhwanJeong added a commit to YunhwanJeong/bookstore that referenced this pull request May 3, 2024
- jest-dom v6.4.3 has esm relevant issue, so it makes the test to be failed.
- someone has already made the GitHub issue and PR to fix, so fix the version to 6.4.2 temporarily.
  - testing-library/jest-dom#599
@MatanBobi MatanBobi requested a review from gnapse May 3, 2024 15:09
@MatanBobi
Copy link
Member Author

Tested locally using npm link, since this is an urgent fix, I'm merging without waiting.

@MatanBobi MatanBobi merged commit e8c8b13 into main May 3, 2024
5 checks passed
@MatanBobi MatanBobi deleted the fix/add-js-suffix-to-isequal branch May 3, 2024 18:26
Copy link

github-actions bot commented May 3, 2024

🎉 This PR is included in version 6.4.5 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

the 6.4.3 have an issue of Cannot find module 'lodash/isEqualWith'
3 participants