Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: toHaveStyle assertion with invalid style (#564) #582

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

fix: toHaveStyle assertion with invalid style (#564) #582

wants to merge 1 commit into from

Commits on Feb 16, 2024

  1. fix: toHaveStyle assertion with invalid style (testing-library#564) 

    Given an invalid declaration such as `fontSize: 8`, due to the missing
unit, the `toHaveStyle` matcher should not pass the following test:

```
render(<div data-testid="element" style={{ fontSize: 8 }} />)
expect(screen.getByTestId('element')).toHaveStyle({ fontSize: 1 })
```

This PR fixes testing-library#564 by adding a more restrictive guard in the matcher's
logic.
    @EduardoSimon
    EduardoSimon committed Feb 16, 2024
    Configuration menu
    Copy the full SHA
    fd3089f View commit details
    Browse the repository at this point in the history