Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(package.json): update main and module file paths #523

Merged
merged 1 commit into from
Aug 23, 2023

Conversation

SteKoe
Copy link
Contributor

@SteKoe SteKoe commented Aug 23, 2023

What:
Updated main and module paths in package.json

Why:
I got the following error after upgrading to 6.1.0 in my project:

SyntaxError: Named export 'parse' not found. The requested module '@adobe/css-tools' is a CommonJS module, which may not support all module.exports as named exports.
CommonJS modules can always be imported via the default export, for example using:

import pkg from '@adobe/css-tools';
const { parse } = pkg;

After updating the paths in package.json and testing using npm link locally, everything works as expected, again.

How:

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

@codecov
Copy link

codecov bot commented Aug 23, 2023

Codecov Report

Merging #523 (5c89350) into main (3d834bb) will not change coverage.
The diff coverage is n/a.

@@            Coverage Diff            @@
##              main      #523   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           27        27           
  Lines          664       664           
  Branches       251       251           
=========================================
  Hits           664       664           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@jgoz jgoz merged commit 853a3e5 into testing-library:main Aug 23, 2023
7 checks passed
@github-actions
Copy link

🎉 This PR is included in version 6.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

@nickmccurdy
Copy link
Member

@all-contributors add @SteKoe for bug code

@allcontributors
Copy link
Contributor

@nickmccurdy

I've put up a pull request to add @SteKoe! 🎉

@gnapse
Copy link
Member

gnapse commented Feb 1, 2024

@all-contributors add @SteKoe for bug code

Copy link
Contributor

@gnapse

I've put up a pull request to add @SteKoe! 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants