Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Ignore comment nodes in toBeEmptyDOMElement #317

Merged
merged 8 commits into from
Jan 12, 2021
Merged

fix: Ignore comment nodes in toBeEmptyDOMElement #317

merged 8 commits into from
Jan 12, 2021

Commits on Dec 17, 2020

  1. feat: Add toContainOnlyComments matcher 

    Adding a new matcher to check if a element only contains comments and no other elements or text.
    @marcelbarner
    marcelbarner committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    dabf6df View commit details
    Browse the repository at this point in the history

  2. typo: Fixing some lint errors

    @marcelbarner
    marcelbarner committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    f74483a View commit details
    Browse the repository at this point in the history

  3. typo: Fixing some lint errors

    @marcelbarner
    marcelbarner committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    aeaba13 View commit details
    Browse the repository at this point in the history

  4. feat: Add logic to ignore comments in toBeEmptyDOMElement 

    After a small discussion move logic from custom matcher to the existing toBeEmptyDOMElement.
    @marcelbarner
    marcelbarner committed Dec 17, 2020
    Configuration menu
    Copy the full SHA
    879a551 View commit details
    Browse the repository at this point in the history

Commits on Dec 20, 2020

  1. feat: Adjust algorithm toBeEmpty

    @marcelbarner
    marcelbarner committed Dec 20, 2020
    Configuration menu
    Copy the full SHA
    c920ee0 View commit details
    Browse the repository at this point in the history

Commits on Dec 21, 2020

  1. Add comments

    @marcelbarner
    marcelbarner committed Dec 21, 2020
    Configuration menu
    Copy the full SHA
    71ba639 View commit details
    Browse the repository at this point in the history

Commits on Jan 12, 2021

  1. chore: Adjust review comments

    @marcelbarner
    marcelbarner committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    f352858 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'master' into only-contains-comments

    @gnapse
    gnapse committed Jan 12, 2021
    Configuration menu
    Copy the full SHA
    559bc43 View commit details
    Browse the repository at this point in the history