-
Notifications
You must be signed in to change notification settings - Fork 379
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: do not explicitly depend on jest assertion utils #250
Conversation
Codecov Report
@@ Coverage Diff @@
## master #250 +/- ##
=========================================
Coverage 100.00% 100.00%
=========================================
Files 23 23
Lines 315 315
Branches 72 72
=========================================
Hits 315 315
Continue to review full report at Codecov.
|
So we'd need a peer dependency on |
Not, it's |
@gnapse any holdup here? |
Nope, my bad. Will merge soon. |
@SimenB there have been a couple of new matchers since you proposed this change. I can take care of it later if you don't beat me to it. |
@gnapse updated |
@SimenB Thanks! |
馃帀 This PR is included in version 5.11.4 馃帀 The release is available on:
Your semantic-release bot 馃摝馃殌 |
What:
Replaced the direct usage of
jest-matcher-utils
andjest-diff
with using the same functions fromthis.utils
injected into each matcher.Why:
I noticed I had old
jest-diff
in mynode_modules
after upgrading to v26 and decided to fix at least one of the entries 馃檪This change allows
jest-dom
to not depend on explicit versions of these dependencies, instead getting the utils fromexpect
during runtime.How:
Search and replace, followed by making the linter happy 馃榾
Checklist: