Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fixed issue where .toHaveStyle wouldn't match when the case was different. #154

Merged

Conversation

connormeredith
Copy link
Contributor

@connormeredith connormeredith commented Oct 29, 2019

What:
Fixed issue where .toHaveStyle wouldn't match when the case was different.

Closes #148.

Why:
Appears to be a regression in #81.

How:
Lowercased both the CSS property and value before comparing.

Checklist:

  • Documentation
  • Tests
  • Updated Type Definitions
  • Ready to be merged

@gnapse gnapse merged commit 9a36d66 into testing-library:master Oct 31, 2019
@gnapse
Copy link
Member

gnapse commented Oct 31, 2019

🎉 This PR is included in version 4.2.2 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

toHaveStyle failing for upper cased style rules in version 4.1.2
4 participants