fix(no-wait-for-side-effects): false positive inside .then()
#645
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added tests and a mention of edge case to rule documentation Refs: testing-library#500
Belco90
requested changes
Sep 12, 2022
Belco90
changed the title
.then().then()
Remove awaits as the promise is waited by .then()
Reuse existing helper function to make solution simpler
Remove await as the promise is waited by .then()
Remove await as the promise is waited by .then()
|
🎉 This PR is included in version 5.6.4 🎉 The release is available on: Your semantic-release bot 📦🚀 |
sjarva
deleted the
pr/no-wait-for-side-effects-false-positive-in-then
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checks
npm run generate:rules-list)npm run generate:configs)Changes
.then(), and if it is, not report itContext
Closes: #500