no-wait-for-side-effects erroring in promise

[Brianzchen]

Plugin version

v4.10.1

ESLint version

v7.31.0

Node.js version

v12.17.0

npm/yarn version

yarn 1.22.10

Operating system

macOS 10.14.6

Bug description

When I use fireEvent within a .then() of waitFor it throws an error

Steps to reproduce

Basically what's shown in the screenshot. I prefer to use .then() as opposed to async await but it throws errors when it shouldn't

Error output/screenshots

No response

ESLint configuration

A few private stuff but the rule sets are

    'testing-library/no-dom-import': 2,
    'testing-library/no-manual-cleanup': 2,
    'testing-library/no-wait-for-empty-callback': 2,
    'testing-library/no-wait-for-side-effects': 2,
    'testing-library/prefer-screen-queries': 2,
    'testing-library/prefer-wait-for': 2,

Rule(s) affected

testing-library/no-wait-for-side-effects

Anything else?

No response

Do you want to submit a pull request to fix this bug?

No

[Belco90]

Hi @Brianzchen! Thanks for reporting, interesting issue. This is definitely a bug and the rule should discard the statements within .then from waitFor promise.

[sjarva]

Thanks @Brianzchen for reporting this! This was nice and easy to fix in #645 🛠️ 🤗

[github-actions]

🎉 This issue has been resolved in version 5.6.4 🎉

The release is available on:

• npm package (@latest dist-tag)
• GitHub release

Your semantic-release bot 📦🚀