Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test(waitFor): Add current behavior for legacy fake timers and requestAnimationFrame #978

Merged
merged 2 commits into from Jun 20, 2021

Conversation

eps1lon
Copy link
Member

@eps1lon eps1lon commented Jun 13, 2021

Identified the bug when trying out v8 alpha in react-spectrum. Waiting for release of jestjs/jest#11567

What:

Add a test for a bug caused by jestjs/jest#11565

Why:

Hoping that we can work around this bug in any way. Would appreciate if anybody got some insight.

How:

Add a test when where we waitFor requestAnimationFrame

Checklist:

  • [ ] Documentation added to the
    docs site
  • Tests
  • [ ] Typescript definitions updated
  • Ready to be merged

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1acae4f:

Sandbox Source
react-testing-library-examples Configuration

@codecov
Copy link

codecov bot commented Jun 13, 2021

Codecov Report

Merging #978 (1acae4f) into alpha (fa3b91c) will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##             alpha      #978   +/-   ##
=========================================
  Coverage   100.00%   100.00%           
=========================================
  Files           25        25           
  Lines          914       914           
  Branches       286       281    -5     
=========================================
  Hits           914       914           
Flag Coverage Δ
node-12 100.00% <ø> (ø)
node-14 100.00% <ø> (ø)
node-16 100.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.


Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fa3b91c...1acae4f. Read the comment docs.

@eps1lon eps1lon mentioned this pull request Jun 13, 2021
7 tasks
@eps1lon
Copy link
Member Author

eps1lon commented Jun 17, 2021

Going to wait for a release of jestjs/jest#11567 which will fix the behavior for legacy timers and break this test.

@eps1lon eps1lon marked this pull request as draft June 17, 2021 06:46
@eps1lon eps1lon changed the title [RFC] test(waitFor): Add current behavior for legacy fake timers and requestAnimationFrame test(waitFor): Add current behavior for legacy fake timers and requestAnimationFrame Jun 20, 2021
@eps1lon
Copy link
Member Author

eps1lon commented Jun 20, 2021

Going to wait for a release of facebook/jest#11567 which will fix the behavior for legacy timers and break this test.

Landing now with a note about future breakage.

@eps1lon eps1lon marked this pull request as ready for review June 20, 2021 07:48
@eps1lon eps1lon merged commit f78d289 into testing-library:alpha Jun 20, 2021
@eps1lon eps1lon deleted the fix/request-animation-frame branch June 20, 2021 07:49
@github-actions
Copy link

🎉 This PR is included in version 8.0.0-alpha.7 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants