Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Pin supported target environment #1170

Merged
merged 2 commits into from Sep 19, 2022
Merged

fix: Pin supported target environment #1170

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
3809120
fix: Pin supported target environment
eps1lon Sep 19, 2022
a06325d
Poke codecov
eps1lon Sep 19, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
19 changes: 19 additions & 0 deletions package.json
View file
Open in desktop
Expand Up @@ -23,6 +23,25 @@
"engines": {
"node": ">=12"
},
"browserslist": [
"and_chr 103",
"and_ff 101",
"and_qq 10.4",
"and_uc 12.12",
"android 103",
"chrome 102",
"edge 102",
"firefox 91",
"ios_saf 12.2-12.5",
"kaios 2.5",
"op_mini all",
"op_mob 64",
"opera 88",
"safari 15.5",
"samsung 17.0",
"samsung 16.0",
"node 12.0"
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kcd-scripts does not use the engines field in its "--bundle" target. This is incorrect since it conflates the module entry with the browser entry. module and main are only for the used module system. Their runtime target needs to be the same. This isn't formally specified but conventionally used by bundlers (see https://esbuild.github.io/api/#main-fields).

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CC/ @kentcdodds

],
"scripts": {
"build": "kcd-scripts build --no-ts-defs --ignore \"**/__tests__/**,**/__node_tests__/**,**/__mocks__/**\" && kcd-scripts build --no-ts-defs --bundle --no-clean",
"format": "kcd-scripts format",
Expand Down