Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix broken build #72

Merged
merged 3 commits into from Aug 17, 2019
Merged

Fix broken build #72

merged 3 commits into from Aug 17, 2019

Conversation

afontcu
Copy link
Member

@afontcu afontcu commented Aug 17, 2019

Build was broken due to linting error:

[lint] 
[lint] /home/travis/build/testing-library/cypress-testing-library/cypress/integration/commands.spec.js
[lint]   43:5  error  Promise should be returned to test its fulfillment or rejection  jest/valid-expect-in-promise
[lint] 
[lint] ✖ 1 problem (1 error, 0 warnings)

@afontcu afontcu changed the title Fix linting issue Fix broken build Aug 17, 2019
@afontcu
Copy link
Member Author

afontcu commented Aug 17, 2019

Well, now it's something else

[test] We expected the binary to be installed here: /home/travis/.cache/Cypress/3.4.1/Cypress/Cypress
[test]
[test] Reasons it may be missing:
[test]
[test] - You're caching 'node_modules' but are not caching this path: /home/travis/.cache/Cypress
[test] - You ran 'npm install' at an earlier build step but did not persist: /home/travis/.cache/Cypress
[test]
[test] Properly caching the binary will fix this error and avoid downloading and unzipping Cypress.
[test]
[test] Alternatively, you can run 'cypress install' to download the binary again.
[test]
[test] https://on.cypress.io/not-installed-ci-error

@simjes
Copy link
Contributor

simjes commented Aug 17, 2019

Seems to have been going on for a little while in the build history, related to cypress-io/cypress#2344

simjes
simjes previously approved these changes Aug 17, 2019
@afontcu
Copy link
Member Author

afontcu commented Aug 17, 2019

Okay, seems fixed. Copied build config from official docs.

@kentcdodds kentcdodds merged commit bb3e157 into master Aug 17, 2019
@kentcdodds kentcdodds deleted the fix-build branch August 17, 2019 18:55
@kentcdodds
Copy link
Member

Thank you!

@kentcdodds
Copy link
Member

@all-contributors please add @simjes for review

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @simjes! 🎉

@kentcdodds
Copy link
Member

@all-contributors please add @afontcu for infrastructure

@allcontributors
Copy link
Contributor

@kentcdodds

I've put up a pull request to add @afontcu! 🎉

@kentcdodds
Copy link
Member

🎉 This PR is included in version 4.1.1 🎉

The release is available on:

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants