@types/testing-library__cypress is breaking my CI build

[williamoliveira]

Apparently it tries to download two versions of Cypress simultaneously. One that I defined ("cypress": "3.8.1") and one at @types/testing-library__cypress ("cypress": "^3.5.0").

Relevant issue at cypress side: cypress-io/cypress#4595.

• cypress-testing-library version: "@testing-library/cypress": "5.0.2"
• node version: 10.18
• npm (or yarn) version: 6.13

CI LOG:

error /app/node_modules/@types/testing-library__cypress/node_modules/cypress: Command failed.
Exit code: 1
Command: node index.js --exec install
Arguments: 
Directory: /app/node_modules/@types/testing-library__cypress/node_modules/cypress
Output:
Installing Cypress (version: 3.6.1)

[16:39:59]  Downloading Cypress     [started]
[16:40:00]  Downloading Cypress      0% 0s [title changed]
[16:40:00]  Downloading Cypress      3% 3s [title changed]
[16:40:00]  Downloading Cypress      4% 5s [title changed]
[16:40:00]  Downloading Cypress      4% 8s [title changed]
[16:40:00]  Downloading Cypress      5% 8s [title changed]
[16:40:00]  Downloading Cypress      6% 8s [title changed]
[16:40:00]  Downloading Cypress      7% 9s [title changed]
[16:40:01]  Downloading Cypress      8% 9s [title changed]
[16:40:01]  Downloading Cypress      9% 9s [title changed]
[16:40:01]  Downloading Cypress      10% 9s [title changed]
[16:40:01]  Downloading Cypress      12% 8s [title changed]
[16:40:01]  Downloading Cypress      13% 8s [title changed]
[16:40:01]  Downloading Cypress      13% 9s [title changed]
[16:40:01]  Downloading Cypress      14% 9s [title changed]
[16:40:01]  Downloading Cypress      15% 9s [title changed]
[16:40:01]  Downloading Cypress      15% 10s [title changed]
[16:40:02]  Downloading Cypress      16% 9s [title changed]
[16:40:02]  Downloading Cypress      18% 9s [title changed]
[16:40:02]  Downloading Cypress      19% 9s [title changed]
[16:40:02]  Downloading Cypress      21% 8s [title changed]
[16:40:02]  Downloading Cypress      22% 8s [title changed]
[16:40:02]  Downloading Cypress      24% 7s [title changed]
[16:40:02]  Downloading Cypress      25% 7s [title changed]
[16:40:02]  Downloading Cypress      26% 7s [title changed]
[16:40:02]  Downloading Cypress      27% 7s [title changed]
[16:40:02]  Downloading Cypress      29% 7s [title changed]
[16:40:03]  Downloading Cypress      31% 6s [title changed]
[16:40:03]  Downloading Cypress      34% 6s [title changed]
[16:40:03]  Downloading Cypress      35% 6s [title changed]
[16:40:03]  Downloading Cypress      36% 6s [title changed]
[16:40:03]  Downloading Cypress      39% 5s [title changed]
[16:40:03]  Downloading Cypress      40% 5s [title changed]
[16:40:03]  Downloading Cypress      45% 4s [title changed]
[16:40:03]  Downloading Cypress      47% 4s [title changed]
[16:40:03]  Downloading Cypress      60% 2s [title changed]
[16:40:04]  Downloading Cypress      73% 1s [title changed]
[16:40:04]  Downloading Cypress      85% 1s [title changed]
[16:40:04]  Downloading Cypress      100% 0s [title changed]
[16:40:06]  Downloading Cypress      100% 0s [failed]
[16:40:06] → The Cypress App could not be downloaded.

Does your workplace require a proxy to be used to access the Internet? If so, you must configure the HTTP_PROXY environment variable before downloading Cypress. Read more: https://on.cypress.io/proxy-configuration

Otherwise, please check network connectivity and try again:

----------

URL: https://download.cypress.io/desktop/3.6.1?platform=linux&arch=x64
Error: Corrupted download

Expected downloaded file to have checksum: 1c887ae436316e59f53be57d0c0a8c1e4b483ad40dd7b7e90d2da740f777eb64f93838d09446a2c48cd68f0292d710f1f53a03afff4e0f2d47d410767c90387a
Computed checksum: 47134d7281c1188d04d0cdfb48d0ee5f4ee69342137a3b21c09228362718055bc63eb58f67c69584c709bcba9193c1e094957d83ca6bbd393dd65ea3b5ab090c

Expected downloaded file to have size: 152981007
Computed size: 162396738

[jcreamer898]

Same issue causing our Jenkins process to asplode. Haha.

Curious, why is @types/testing-library__cypress even listed as a dependency? Shouldn't that be up to the consumer of this project to install?

I bet this would fix itself if @types/testing-library__cypress was moved to devDependencies eh?

[Niceplace]

I'm experiencing the same issue here but @testing-library/cypress": "5.0.2" is already in our devDependencies :/

[weyert]

Guess, we should make cypress a peer dependency?

[nhducit]

I think you guys can workaround by using yarn resolution

package.json
https://yarnpkg.com/lang/en/docs/selective-version-resolutions/

  "resolutions": {
    "cypresss": "1.2.3" // use whichever version you want
  }

[kentcdodds]

@weyert's suggestion is correct. It should be a peerDep with a very generous version range.

[kentcdodds]

I just made a PR: DefinitelyTyped/DefinitelyTyped#41917

Closing here because there's nothing we can do in this repo at this point :) Thanks! (Also, sorry it took me so long to address this. I kinda took a break and it's been hard to get back on top of things 😅)

[jcreamer898]

Thanks @kentcdodds!

[kaiyoma]

What happened here? It looks like the PR was undone and this types package is still doing a full install of Cypress. We're seeing two different versions of Cypress in our node_modules because of this. Why aren't peer dependencies being used?

[jbojcic1]

I still have this issue. I had Cypress 4.12.1 and I installed @testing-library/cypress 6.0.1 which has @types/testing-library__cypress ^5.0.6 as a dependency. Ended up with two Cypress versions 4.12.1 and 5.0.0 which was breaking my CI build.

[kentcdodds]

Try @testing-library/cypress@7.0.0-beta.1 :)

[kentcdodds]

(Note, that should work because the types are now within the module)