chore(e2e-dev-runtime): bump @testing-library/cypress and adjust current data updates testing setup #26500
Conversation
gatsbot
bot
added
the
status: triage needed
| if (!(webhookBody && webhookBody[`fake-data-update`])) { | ||
| await api.reset() | ||
| } |
There was a problem hiding this comment.
This is meant to result in "initial" data state, unless we want to trigger refresh/update explicitly for this plugin
Gatsby Cloud Build Reportclient-only-paths 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 18s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-styled-components 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11s PerformanceLighthouse report
|
Gatsby Cloud Build Reportusing-reach-skip-nav 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 11s PerformanceLighthouse report
|
Gatsby Cloud Build Reportgatsby-master 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 16s PerformanceLighthouse report
|
pieh
added
type: maintenance
| @@ -15,17 +15,17 @@ describe(`Gatsby Preview (Updating)`, () => { | |||
| it(`displays initial data`, () => { | |||
| cy.get(`li:eq(0) a`).click().waitForRouteChange() | |||
|
|
|||
| cy.queryByText(`Hello World (1)`).should(`exist`) | |||
| cy.findByText(`Hello World (1)`).should(`exist`) | |||
There was a problem hiding this comment.
That's one of breaking changes in @testing-library/cypress@6 - https://github.com/testing-library/cypress-testing-library/releases/tag/v6.0.0
This comment applies to all replacements like that here
Gatsby Cloud Build Reportgatsby 🎉 Your build was successful! See the Deploy preview here. Build Details🕐 Build time: 5m |
| }, | ||
| "resolutions": { | ||
| "cypress": "3.4.1" |
There was a problem hiding this comment.
Fix/workaround for https://app.circleci.com/pipelines/github/gatsbyjs/gatsby/48158/workflows/3227d59e-b7ae-4eeb-b109-06a9712b44c2/jobs/491859 ( because of deps spaghetti it tries to install 2 instances of cypress and cypress use single tmp location for binary download and this results in 2 different downloads writing things to same filepath which corrupts it). This is somewhat forcing single instance of cypress to workaround this problem
Some existing tickets about this problem:
- @types/testing-library__cypress is breaking my CI build testing-library/cypress-testing-library#98
- Installation fails when installing two different versions of Cypress during the same yarn install step. cypress-io/cypress#7951
- When downloading 2 versions of Cypress simultaneously, one clobbers the other resulting in nondescript error and exit cypress-io/cypress#4595
…ent data updates testing setup (gatsbyjs#26500) * chore(e2e-dev-runtime): bump @testing-library/cypress * chore(e2e-dev-runtime): scope fake-data source plugin data refreshes * force single cypress version ref: testing-library/cypress-testing-library#98
Description
This PR does 2 things:
@testing-library/cypressfixes the problem that forced skipping one of the tests (for ref - breaking changes for v5 and v6 respectively - https://github.com/testing-library/cypress-testing-library/releases/tag/v5.0.0 and https://github.com/testing-library/cypress-testing-library/releases/tag/v6.0.0