Skip to content

Commit

Permalink
feat: upgrade @testing-library/dom to v10 (#447)
Browse files Browse the repository at this point in the history
BREAKING CHANGE:

New version of @testing-library/dom changes various roles. Check out the changed tests in testing-library/dom-testing-library@2c57055 to get an overview about what changed.
  • Loading branch information
timdeschryver committed Apr 18, 2024
1 parent e49d2ce commit c378423
Show file tree
Hide file tree
Showing 3 changed files with 3 additions and 3 deletions.
2 changes: 1 addition & 1 deletion .github/workflows/ci.yml
Original file line number Diff line number Diff line change
Expand Up @@ -22,7 +22,7 @@ jobs:

strategy:
matrix:
node-version: ${{ fromJSON((github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta') && '[20]' || '[16, 18, 20]') }}
node-version: ${{ fromJSON((github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta') && '[20]' || '[18, 20]') }}
os: ${{ fromJSON((github.ref == 'refs/heads/main' || github.ref == 'refs/heads/beta') && '["ubuntu-latest"]' || '["ubuntu-latest", "windows-latest"]') }}
runs-on: ${{ matrix.os }}

Expand Down
2 changes: 1 addition & 1 deletion package.json
Original file line number Diff line number Diff line change
Expand Up @@ -39,7 +39,7 @@
"@angular/router": "17.3.2",
"@ngrx/store": "17.1.0",
"@nx/angular": "17.2.8",
"@testing-library/dom": "^9.0.0",
"@testing-library/dom": "^10.0.0",
"rxjs": "7.8.0",
"tslib": "~2.3.1",
"zone.js": "0.14.2"
Expand Down
2 changes: 1 addition & 1 deletion projects/testing-library/package.json
Original file line number Diff line number Diff line change
Expand Up @@ -35,7 +35,7 @@
"@angular/core": ">= 17.0.0"
},
"dependencies": {
"@testing-library/dom": "^9.0.0",
"@testing-library/dom": "^10.0.0",
"tslib": "^2.3.1"
},
"publishConfig": {
Expand Down

0 comments on commit c378423

Please sign in to comment.