New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[feature] add h2 / spdy support #1302
base: master
Are you sure you want to change the base?
Conversation
I think moving to h2 makes sense, but @gabrielcsapo some I questions (mostly to understand impact):
|
+1 on Stefan's comment on performance impact. One caveat that I think needs discussion is that the cert used by testem will be self signed certs that the browsers will likely first redirect to a warning page, which I feel could be a breaking change. (Unless we there are flags for browsers that can bypass it?) |
@step2yeung good point, could you investigate further? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Why do we have both a package-lock.json
and yarn.lock
?
@@ -45,6 +46,7 @@ | |||
"rimraf": "^2.4.4", | |||
"socket.io": "^2.1.0", | |||
"spawn-args": "^0.2.0", | |||
"spdy": "^3.4.7", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm slightly concerned that this is unmaintained...
Is there any reason we can't use the built-in http2
module when present?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Right yeah I am under the mind that we should be using the built in modules for this instead of using express, which has had an open RB for almost 3 years for this support.
Chrome has But i don't think there are similar flags that is accepted by other supported browsers. |
What did I do?
Set up the initial pieces for serving http2 content in testem
What needs to be done