Graciously fall back from failed cloneDeep #469
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I hand-merged this because there were several edge cases I'd mentioned in the other thread that needed to be handled in order to support this change without potentially violating the contract of the Released as 3.16.2 |
Thank you! Sorry for the late reply, was away on holidays. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In some cases
cloneDeepcan fail, rendering the stub unusable. This PR adds error handling for that case, falling back to using the originalargsobject by reference. See discussion in #417.@searls, please let me know if there's other methods of error handling. I searched for
try/catchblocks in the source and only found some that were not relevant for this particular use case.