New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(core): Private registry #566
feat(core): Private registry #566
Conversation
i wonder if this is what the java client does underneath, have almost no opportunity to find out independently. i explored the testcontainers side of java yesterday and realized that i need to look at docker-java to find any real answers anyways. |
Added tests |
Some documentation on how I tested it: |
wdyt about testing using this module - https://github.com/testcontainers/testcontainers-python/tree/main/modules/registry - i know it inverts the dependencies on their head a bit. maybe we can just copy and paste the code as it is just a part of the test suite and therefore not actually being published to pypi. doesn't have to be a part of this PR, just think that would be the most comprehensive/on-brand test. maybe its not actually a blocker, just pausing to think cause when this is merged, there is no more fixes for 4.4 line (RP will set the version in #551 to |
was thinking the same thing :) |
Ok, so I'll just compile some research here for the future:
If this actually works and doesn't break anything, I think this is as close as were going to get. |
probably another at this point. its more than welcome, but have to keep merging things or else they get stale and conflicted and unmergable. |
🤖 I have created a release *beep* *boop* --- ## [4.5.0](testcontainers-v4.4.1...testcontainers-v4.5.0) (2024-05-25) ### Features * **core:** Private registry ([#566](#566)) ([59fbcfa](59fbcfa)) ### Bug Fixes * added types to exec & tc_properties_get_tc_host ([#561](#561)) ([9eabb79](9eabb79)) * on windows, DockerCompose.get_service_host returns an unusable "0.0.0.0" - adjust to 127.0.0.1 ([#457](#457)) ([2aa3d37](2aa3d37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Ref testcontainers#562 This enhancement adds capability to utilize the env var `DOCKER_AUTH_CONFIG` in-order to login to a private docker registry. --------- Co-authored-by: David Ankin <daveankin@gmail.com>
🤖 I have created a release *beep* *boop* --- ## [4.5.0](testcontainers/testcontainers-python@testcontainers-v4.4.1...testcontainers-v4.5.0) (2024-05-25) ### Features * **core:** Private registry ([testcontainers#566](testcontainers#566)) ([59fbcfa](testcontainers@59fbcfa)) ### Bug Fixes * added types to exec & tc_properties_get_tc_host ([testcontainers#561](testcontainers#561)) ([9eabb79](testcontainers@9eabb79)) * on windows, DockerCompose.get_service_host returns an unusable "0.0.0.0" - adjust to 127.0.0.1 ([testcontainers#457](testcontainers#457)) ([2aa3d37](testcontainers@2aa3d37)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). Co-authored-by: github-actions[bot] <41898282+github-actions[bot]@users.noreply.github.com>
Ref #562
This enhancement adds capability to utilize the env var
DOCKER_AUTH_CONFIG
in-order to login to a private docker registry.