fix: typing in core #504
Draft
fix: typing in core #504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Nice! Glad you found the time before me! Good start! 🙏 |
This was referenced Mar 30, 2024
jankatins
reviewed
Apr 26, 2024
jankatins
reviewed
Apr 26, 2024
| @@ -78,7 +78,10 @@ def wait_for(condition: Callable[..., bool]) -> bool: | |||
|
|
|||
|
|
|||
| def wait_for_logs( | |||
| container: "DockerContainer", predicate: Union[Callable, str], timeout: Optional[float] = None, interval: float = 1 | |||
| container: "DockerContainer", | |||
| predicate: Union[Callable[..., Any], str], | |||
There was a problem hiding this comment.
Shouldn't the callable here be Callable[(str,) bool]? It's used as if predicate(stdout) or predicate(stderr):
There was a problem hiding this comment.
in java it also takes regex i dont remember if that is the case here but i will leave this thread open to review when and if this PR goes on. I think it belongs in a draft state for now. i just wanted to record the results of going through the exercise to add types. for example, some of the places we return ports are actually str | int (well, union, for 3.8 compatibility)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.