Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

add SingleStore container #354

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

add SingleStore container #354

wants to merge 1 commit into from

Conversation

vgerya
Copy link

@vgerya vgerya commented May 16, 2023 •
edited

I fixed pylint issues,
but I still cannot set up requirements locally (macbook, m1, Python 3.10.10)

Collecting pymssql==2.2.7
  Using cached pymssql-2.2.7.tar.gz (170 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pymssql
  Building wheel for pymssql (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for pymssql (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      setup.py: platform.system() => Darwin
      setup.py: platform.architecture() => ('64bit', '')
      setup.py: platform.libc_ver() => ('', '')
      setup.py: include_dirs => []
      setup.py: library_dirs => []
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-13.3-arm64-cpython-310
      creating build/lib.macosx-13.3-arm64-cpython-310/pymssql
      copying src/pymssql/__init__.py -> build/lib.macosx-13.3-arm64-cpython-310/pymssql
      running build_ext
      cythoning src/pymssql/_mssql.pyx to src/pymssql/_mssql.c
      cythoning src/pymssql/_pymssql.pyx to src/pymssql/_pymssql.c
      building 'pymssql._mssql' extension
      creating build/temp.macosx-13.3-arm64-cpython-310
      creating build/temp.macosx-13.3-arm64-cpython-310/src
      creating build/temp.macosx-13.3-arm64-cpython-310/src/pymssql
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Users/vheria/.pyenv/versions/test-contaniers-venv/include -I/Users/vheria/.pyenv/versions/3.10.10/include/python3.10 -c src/pymssql/_mssql.c -o build/temp.macosx-13.3-arm64-cpython-310/src/pymssql/_mssql.o -DMSDBLIB
      src/pymssql/_mssql.c:747:10: fatal error: 'sqlfront.h' file not found
      #include "sqlfront.h"
               ^~~~~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pymssql
Failed to build pymssql
ERROR: Could not build wheels for pymssql, which is required to install pyproject.toml-based projects

@vgerya vgerya marked this pull request as ready for review May 16, 2023 11:46
@tillahoffmann
Copy link
Collaborator

Thanks for the contribution, @vgerya. The GitHub Action run has now built the requirement files. Updating them (as described in the pull request template) should facilitate the tests passing.

@vgerya
Copy link
Author

vgerya commented May 17, 2023

Thanks for the contribution, @vgerya. The GitHub Action run has now built the requirement files. Updating them (as described in the pull request template) should facilitate the tests passing.

Thank for support in review of this PR.
There was a wrong import in doctest of SingleStoreContainer class.
it's fixed

@vgerya vgerya force-pushed the singlestore branch 2 times, most recently from 62b6589 to a785684 Compare May 17, 2023 19:26
@tillahoffmann
Copy link
Collaborator

There are still some issues with dependencies. Have a look here for step-by-step instructions: https://github.com/testcontainers/testcontainers-python/blob/main/.github/PULL_REQUEST_TEMPLATE/new_container.md

@vgerya
Copy link
Author

vgerya commented May 18, 2023

I fixed pylint issues, but I still cannot set up requirements locally (macbook, m1, Python 3.10.10)

Collecting pymssql==2.2.7
  Using cached pymssql-2.2.7.tar.gz (170 kB)
  Installing build dependencies ... done
  Getting requirements to build wheel ... done
  Preparing metadata (pyproject.toml) ... done
Building wheels for collected packages: pymssql
  Building wheel for pymssql (pyproject.toml) ... error
  error: subprocess-exited-with-error
  
  × Building wheel for pymssql (pyproject.toml) did not run successfully.
  │ exit code: 1
  ╰─> [25 lines of output]
      setup.py: platform.system() => Darwin
      setup.py: platform.architecture() => ('64bit', '')
      setup.py: platform.libc_ver() => ('', '')
      setup.py: include_dirs => []
      setup.py: library_dirs => []
      running bdist_wheel
      running build
      running build_py
      creating build
      creating build/lib.macosx-13.3-arm64-cpython-310
      creating build/lib.macosx-13.3-arm64-cpython-310/pymssql
      copying src/pymssql/__init__.py -> build/lib.macosx-13.3-arm64-cpython-310/pymssql
      running build_ext
      cythoning src/pymssql/_mssql.pyx to src/pymssql/_mssql.c
      cythoning src/pymssql/_pymssql.pyx to src/pymssql/_pymssql.c
      building 'pymssql._mssql' extension
      creating build/temp.macosx-13.3-arm64-cpython-310
      creating build/temp.macosx-13.3-arm64-cpython-310/src
      creating build/temp.macosx-13.3-arm64-cpython-310/src/pymssql
      clang -Wno-unused-result -Wsign-compare -Wunreachable-code -DNDEBUG -g -fwrapv -O3 -Wall -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Library/Developer/CommandLineTools/SDKs/MacOSX.sdk/usr/include -I/Users/vheria/.pyenv/versions/test-contaniers-venv/include -I/Users/vheria/.pyenv/versions/3.10.10/include/python3.10 -c src/pymssql/_mssql.c -o build/temp.macosx-13.3-arm64-cpython-310/src/pymssql/_mssql.o -DMSDBLIB
      src/pymssql/_mssql.c:747:10: fatal error: 'sqlfront.h' file not found
      #include "sqlfront.h" 
               ^~~~~~~~~~~~
      1 error generated.
      error: command '/usr/bin/clang' failed with exit code 1
      [end of output]
  
  note: This error originates from a subprocess, and is likely not a problem with pip.
  ERROR: Failed building wheel for pymssql
Failed to build pymssql
ERROR: Could not build wheels for pymssql, which is required to install pyproject.toml-based projects

This issue can be fixed by https://stackoverflow.com/a/70333974/352839

@vgerya vgerya force-pushed the singlestore branch 2 times, most recently from 7cb8be9 to 977f8b4 Compare May 18, 2023 07:07
@tillahoffmann
Copy link
Collaborator

tillahoffmann commented May 18, 2023 •
edited

This issue can be fixed by https://stackoverflow.com/a/70333974/352839

Great pointer. However, this is not something that we can fix in this repo because it depends on the local runtime. Maybe a pointer somewhere in the documentation could be useful.

tillahoffmann
tillahoffmann requested changes May 19, 2023
View reviewed changes
singlestore/testcontainers/singlestore/__init__.py Outdated Show resolved Hide resolved
singlestore/testcontainers/singlestore/__init__.py Outdated Show resolved Hide resolved
singlestore/testcontainers/singlestore/__init__.py Outdated Show resolved Hide resolved
singlestore/tests/test_singlestore.py
Comment on lines +8 to +10
license_key=('BGE5YzE5NTdmN2I1NDQ4MjhhNTQ0MTM4YWQ4Y2Q5ZWNiAAAAAAA'
'AAAAEAAAAAAAAAAwwNQIYKbH2LOLeT189H+nBdRagLdLboVuJTs'
'gJAhkAtSepSZkq0Zn4FDVtvZyASWzovR2OeeyiAA==')
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this a commercial license key?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's free license
image

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You may want to check whether the license terms allow you to share the key.

singlestore/testcontainers/singlestore/__init__.py Outdated Show resolved Hide resolved
@alexanderankin alexanderankin added the community-feat feature but its a community module so we wont bump tc core for it label Mar 26, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tillahoffmann tillahoffmann tillahoffmann requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
community-feat feature but its a community module so we wont bump tc core for it 🚀 enhancement ✨ package: new
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@vgerya @tillahoffmann @alexanderankin