New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Cockroach DB Container Support #281
base: main
Are you sure you want to change the base?
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #281 +/- ##
=======================================
Coverage ? 87.06%
=======================================
Files ? 31
Lines ? 866
Branches ? 61
=======================================
Hits ? 754
Misses ? 79
Partials ? 33 ☔ View full report in Codecov by Sentry. |
I'm an engineer from CockroachDB - this looks good to me! |
dbfb587
to
2cb2e63
Compare
Please let me know if there's anything else that I need to do to get this merged. I'm trying to keep it up to date with Master at this point. |
There a few more major-ish changes to prepare for v4.x (e.g. #296). I'd suggest not updating the PR until then (but thank you for putting the work in to keep it up to date). Shall I let you know when |
Yes Please. Thanks for the follow up. |
Add Test Tweak Naming, add to docs Make insecure mode conditional on presence of password Fix Tests Address Linting
e24db55
to
d092695
Compare
@tillahoffmann Is the Main branch ready enough to update this to the new patterns? |
Yes, fingers crossed. |
You have implemented a new container and would like to contribute it? Great! Here are the necessary steps:
testcontainers
directory (such astestcontainers/my_fancy_container.py
).extras_require
section ofsetup.py
.extra_requires
key torequirements.in
.make requirements
from the root directory.tests
directory, e.g.tests/test_my_fancy_container.py
.my_fancy_container
) to thetest-components
matrix in.github/workflows/main.yml
to ensure the tests are run.master
(or mergedmaster
into your development branch).