Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix None/True/False handling in Arango. #222

Merged
merged 3 commits into from
Jun 14, 2022

Conversation

tillahoffmann
Copy link
Collaborator

@tillahoffmann tillahoffmann commented Jun 14, 2022

Minor changes to let None default to environment variables and True/False to be used as is. Cf. #221.

@codecov-commenter
Copy link

Codecov Report

Merging #222 (3f720fa) into master (c0dc701) will increase coverage by 0.03%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #222      +/-   ##
==========================================
+ Coverage   86.52%   86.56%   +0.03%     
==========================================
  Files          27       27              
  Lines         720      722       +2     
  Branches       65       65              
==========================================
+ Hits          623      625       +2     
  Misses         76       76              
  Partials       21       21              
Impacted Files Coverage Δ
testcontainers/arangodb.py 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c0dc701...3f720fa. Read the comment docs.

@tillahoffmann tillahoffmann merged commit 99a3252 into testcontainers:master Jun 14, 2022
@tillahoffmann tillahoffmann deleted the arango-fix branch June 14, 2022 19:40
@nshine
Copy link
Contributor

nshine commented Jun 16, 2022

Hi @tillahoffmann / @thedrow / @SergeyPirogov
Can you please trigger new release ?

@tillahoffmann
Copy link
Collaborator Author

@nshine, that should already be done. Let me know if you have a problem installing 3.6.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants