Support flyway v10.4.1 #39
Open
+12
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigMikeCodes
changed the title
| <dependency> | ||
| <groupId>org.flywaydb</groupId> | ||
| <artifactId>flyway-database-postgresql</artifactId> | ||
| <version>${flyway-core.version}</version> |
There was a problem hiding this comment.
Shouldn't this be an optional one? If I choose MySQL then this is extra dependency.
There was a problem hiding this comment.
Agreed, I don't think we need this dependency at all and it should be provided by the users of the library.
There was a problem hiding this comment.
Shouldn't this be an optional one? If I choose MySQL then this is extra dependency.
Yes, we don't need to force specific flyway/liquibase versions
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi, this is a relatively simple change to bump the supported flyway version to 10.4.1.
When using this plugin against a postgres 16.1 database i was getting a warning from flyway that the postgres version was unsupported so thought i'd do a quick PR to bump the flyway version.
I've had to add a new depenedency
flyway-database-postgresqldue to underlying changes in flyway between v9 & v10.jackson-annotationsis excluded from the the testcontainers dependency due to a version conflict that resulted in a runtime CassNotFoundException.Any feedback on this is greatly appreciated :)