Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Faster Kafka container #782

Merged
merged 1 commit into from Jul 25, 2018
Merged

Faster Kafka container #782

merged 1 commit into from Jul 25, 2018

Conversation

bsideup
Copy link
Member

@bsideup bsideup commented Jul 13, 2018

Set KAFKA_GROUP_INITIAL_REBALANCE_DELAY_MS to 0 in KafkaContainer to speed up the tests

https://kafka.apache.org/documentation/

A new config, group.initial.rebalance.delay.ms, was introduced. This config specifies the time, in milliseconds, that the GroupCoordinator will delay the initial consumer rebalance. The rebalance will be further delayed by the value of group.initial.rebalance.delay.ms as new members join the group, up to a maximum of max.poll.interval.ms. The default value for this is 3 seconds. During development and testing it might be desirable to set this to 0 in order to not delay test execution time.

@bsideup bsideup added this to the next milestone Jul 13, 2018
@bsideup bsideup requested review from rnorth and kiview July 13, 2018 20:06
Copy link
Member

@kiview kiview left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch. Have you checked of the environment variable is used in the confluent image? I'm not sure if every property is automatically exposed as an ENV variable in the image.

@bsideup
Copy link
Member Author

bsideup commented Jul 13, 2018

@kiview I did :) Also, I see a notable change in the test duration when I change this property

@bsideup bsideup merged commit 6e7c8a6 into master Jul 25, 2018
@bsideup bsideup deleted the faster_kafka branch July 25, 2018 13:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants