Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Expose Redpanda schema registry #5994

Merged
merged 5 commits into from Oct 27, 2022
Merged

Expose Redpanda schema registry #5994

Show file tree
Hide file tree
Changes from 4 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
8ac668c
Expose Redpanda out of box schema registry
Oct 17, 2022
25e9519
Add documentation
Oct 19, 2022
4453ac1
Extend schema registry tests
Oct 19, 2022
b501e7f
Remove unecessary test comments
Oct 19, 2022
7a36f32
switch from Hamcrest to AssertJ matchers
Oct 27, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
6 changes: 6 additions & 0 deletions docs/modules/redpanda.md
View file
Open in desktop
Expand Up @@ -19,6 +19,12 @@ Now your tests or any other process running on your machine can get access to ru
[Bootstrap Servers](../../modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java) inside_block:getBootstrapServers
<!--/codeinclude-->

Redpanda also provides a schema registry implementation. Like the Redpanda broker, you can access by using the following schema registry location:

<!--codeinclude-->
[Schema Registry](../../modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java) inside_block:getSchemaRegistryAddress
<!--/codeinclude-->

## Adding this module to your project dependencies

Add the following dependency to your `pom.xml`/`build.gradle` file:
Expand Down
1 change: 1 addition & 0 deletions modules/redpanda/build.gradle
View file
Open in desktop
Expand Up @@ -5,4 +5,5 @@ dependencies {

testImplementation 'org.apache.kafka:kafka-clients:3.3.0'
testImplementation 'org.assertj:assertj-core:3.23.1'
testImplementation 'io.rest-assured:rest-assured:5.2.0'
}
11 changes: 9 additions & 2 deletions modules/redpanda/src/main/java/org/testcontainers/redpanda/RedpandaContainer.java
View file
Open in desktop
Expand Up @@ -18,6 +18,8 @@ public class RedpandaContainer extends GenericContainer<RedpandaContainer> {

private static final int REDPANDA_PORT = 9092;

private static final int SCHEMA_REGISTRY_PORT = 8081;

private static final String STARTER_SCRIPT = "/testcontainers_start.sh";

public RedpandaContainer(String image) {
Expand All @@ -33,7 +35,7 @@ public RedpandaContainer(DockerImageName imageName) {
throw new IllegalArgumentException("Redpanda version must be >= v22.2.1");
}

withExposedPorts(REDPANDA_PORT);
withExposedPorts(REDPANDA_PORT, SCHEMA_REGISTRY_PORT);
withCreateContainerCmdModifier(cmd -> {
cmd.withEntrypoint("sh");
});
Expand All @@ -49,12 +51,17 @@ protected void containerIsStarting(InspectContainerResponse containerInfo) {

command += "/usr/bin/rpk redpanda start --mode dev-container ";
command += "--kafka-addr PLAINTEXT://0.0.0.0:29092,OUTSIDE://0.0.0.0:9092 ";
command += "--advertise-kafka-addr PLAINTEXT://kafka:29092,OUTSIDE://" + getHost() + ":" + getMappedPort(9092);
command +=
"--advertise-kafka-addr PLAINTEXT://127.0.0.1:29092,OUTSIDE://" + getHost() + ":" + getMappedPort(9092);
eddumelendez marked this conversation as resolved.
Show resolved Hide resolved

copyFileToContainer(Transferable.of(command, 0777), STARTER_SCRIPT);
}

public String getBootstrapServers() {
return String.format("PLAINTEXT://%s:%s", getHost(), getMappedPort(REDPANDA_PORT));
}

public String getSchemaRegistryAddress() {
return String.format("http://%s:%s", getHost(), getMappedPort(SCHEMA_REGISTRY_PORT));
}
}
30 changes: 30 additions & 0 deletions modules/redpanda/src/test/java/org/testcontainers/redpanda/RedpandaContainerTest.java
View file
Open in desktop
@@ -1,6 +1,7 @@
package org.testcontainers.redpanda;

import com.google.common.collect.ImmutableMap;
import io.restassured.RestAssured;
import org.apache.kafka.clients.admin.AdminClient;
import org.apache.kafka.clients.admin.AdminClientConfig;
import org.apache.kafka.clients.admin.NewTopic;
Expand All @@ -26,6 +27,7 @@
import static org.assertj.core.api.Assertions.assertThat;
import static org.assertj.core.api.Assertions.assertThatThrownBy;
import static org.assertj.core.api.Assertions.tuple;
import static org.hamcrest.Matchers.hasItems;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be replaced with Assertj usage.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@gustavomonarin are you able to fix this? If not, we can do it. The PR is almost done.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Of course. Should be fixed on 7a36f32.

Let me know if i missed something.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The branch is now slightly behind the origin / master. Should i rebase? (I am not sure if rebase could affect anything with the review process...)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

no need to do so. I'm waiting for the checks to pass and I will merge it. Thanks @gustavomonarin !


public class RedpandaContainerTest {

Expand Down Expand Up @@ -64,6 +66,34 @@ public void testNotCompatibleVersion() {
.hasMessageContaining("Redpanda version must be >= v22.2.1");
}

@Test
public void testSchemaRegistry() {
try (RedpandaContainer container = new RedpandaContainer(REDPANDA_DOCKER_IMAGE)) {
container.start();

String subjectsEndpoint = String.format(
"%s/subjects",
// getSchemaRegistryAddress {
container.getSchemaRegistryAddress()
// }
);

String subjectName = String.format("test-%s-value", UUID.randomUUID());

RestAssured
.given()
.contentType("application/vnd.schemaregistry.v1+json")
.pathParam("subject", subjectName)
.body("{\"schema\": \"{\\\"type\\\": \\\"string\\\"}\"}")
.when()
.post(subjectsEndpoint + "/{subject}/versions")
.then()
.statusCode(200);

RestAssured.given().when().get(subjectsEndpoint).then().statusCode(200).body("$", hasItems(subjectName));
}
}

private void testKafkaFunctionality(String bootstrapServers) throws Exception {
testKafkaFunctionality(bootstrapServers, 1, 1);
}
Expand Down