Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove jcenter from list of repositories #3755

Closed
wants to merge 1 commit into from
Closed

Remove jcenter from list of repositories #3755

wants to merge 1 commit into from

Conversation

gastaldi
Copy link

@gastaldi gastaldi commented Feb 4, 2021

@slonopotamus
Copy link

Note that this is not the only dependency on jcenter/bintray in testcontainers.

As far as I understand, testcontainers currently publishes its releases via bintray: https://github.com/testcontainers/testcontainers-java/blob/master/gradle/bintray.gradle

@bsideup
Copy link
Member

bsideup commented Feb 6, 2021

@gastaldi could you please remove it from everywhere, not only the top level file? There are a few entries (e.g. examples)

@gastaldi
Copy link
Author

gastaldi commented Feb 8, 2021

@bsideup My Gradle-fu is a bit limited, but I think I removed every reference from the repository, except for the RELEASING.md, which says that Bintray syncs with Central and I have no idea how to do that in Gradle :)

@stale
Copy link

stale bot commented Jun 18, 2021

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this.

@stale stale bot added the stale label Jun 18, 2021
@rnorth rnorth removed the stale label Jun 24, 2021
@@ -2,7 +2,6 @@ plugins {
id 'io.franzbecker.gradle-lombok' version '3.1.0'
id 'nebula.provided-base' version '3.0.3'
id 'com.github.johnrengelman.shadow' version '5.2.0'
id "com.jfrog.bintray" version "1.8.4" apply false
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not quite as easy as this; we need to replace our bintray publication with something else, and I'm afraid that this is a task that core maintainers need to do.

Removal of jcenter() from repositories blocks is still valuable, though!

@bsideup
Copy link
Member

bsideup commented May 17, 2022

Seems to be superseeded by #4931, sorry! Thanks for your time working on this PR tho, much appreciated!

@bsideup bsideup closed this May 17, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants