Add support for dynamodb-local #3557
Conversation
| * @deprecated use {@link DynamoDbContainer (DockerImageName)} instead | ||
| */ | ||
| @Deprecated | ||
| public DynamoDbContainer() { |
There was a problem hiding this comment.
do we need this constructor? can it be removed?
| DockerImageName.parse("amazon/dynamodb-local"); | ||
| private static final int MAPPED_PORT = 8000; | ||
|
|
||
| public DynamoDbContainer(String dockerImageName) { |
There was a problem hiding this comment.
This constructor isn't needed. Can you remove it?
There was a problem hiding this comment.
You're right this contractor is not needed. I added only because I found it in most of the other modules. Is there any convention suggesting I should keep it?
|
FYI DynamoDB local is already supported by LocalStackContainer. As it is a general solution to many AWS services, do you still think we need a module? |
|
@bsideup I thought a specific module could be more discoverable given that DynamoDB Local is the suggested way to run tests against DynamoDB in the official AWS documentation (reference). One more point is that this module uses the latest AWS Java SDK, while both Dynalite and LocalStackContainer uses the old one. |
|
TBH I think we should avoid adding another module for DynamoDB. As @bsideup mentioned, Localstack already supports it and we have the dynalite module too. Arguably, our dynalite module should be retired because it's old and I can't see it adding any value after so long. For us, as volunteer maintainers, adding a new module is quite a commitment in terms of future maintenance (which is why we have an extensive checklist for it). Sadly in this case with the functionality being quite similar to existing modules, I think we really can't accept the contribution at the moment. Sorry if this is disappointing. |
|
@rnorth @bsideup thanks for the feedback. I will close this PR. Is there any plan to update AWS SDK in the LocalStackContainer, because #1442 seems to be closed? Currently, we have duplicated some code to not leak AWS SDK v1 in our project, which is not ideal. It would be better having native support coming from Testcontainers for AWS SDK 2. |
Define a TestContainer using the official AWS DynamoDb local docker image as an alternative to Dynalite.
This new Testcontainer uses the latest version of AWS SDK, instead of the old AWS SDK currently used in the Dynalite container.