Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reduce severity of warning for failed auth config lookups (fixes #1399) #3353

Merged
merged 3 commits into from
Oct 29, 2020

Conversation

DevilzOwn
Copy link
Contributor

No description provided.

@binkley
Copy link

binkley commented Oct 21, 2020

Thank you for this PR -- I can't approve (not a project member), but especially the additional provided detail on the Docker repo would help me understand the output, and being INFO rather than WARN makes more sense to me.

@rnorth
Copy link
Member

rnorth commented Oct 21, 2020

Build failure seems unrelated. Have raised #3378 to fix.

@DevilzOwn
Copy link
Contributor Author

@rnorth Thanks for fixing the build :). Can you please help in getting this merged?

Copy link
Member

@rnorth rnorth left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks @DevilzOwn!

@rnorth rnorth changed the title [1399]: fix the warning - Failure when attempting to lookup auth config Reduce severity of warning for failed auth config lookups (fixes #1399) Oct 29, 2020
@rnorth rnorth added this to the 1.15.0 milestone Oct 29, 2020
@rnorth rnorth merged commit e97fd3d into testcontainers:master Oct 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants