-
-
Notifications
You must be signed in to change notification settings - Fork 1.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename Docker image name and make it public #3350
Conversation
b7679d6
to
22c17ef
Compare
@@ -61,7 +56,6 @@ public void stopRestClient() throws IOException { | |||
} | |||
} | |||
|
|||
@SuppressWarnings("deprecation") // Using deprecated constructor for verification of backwards compatibility |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that this change is not related to the goal of this PR and is a leftover from #2320
It's probably better to use the same way to declare an image as we have with other modules like couchbase for example. It has also a positive "side" effect to highlight the fact that it's a good practice to set the tag when building the container.
22c17ef
to
c1771fa
Compare
I think we might have to delay this a bit. I've put my thinking into a new issue ticket, which we need to work out: #3381 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
Not stale 😉 |
This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. If you believe this is a mistake, please reply to this comment to keep it open. If there isn't one already, a PR to fix or at least reproduce the problem in a test case will always help us get back on track to tackle this. |
/** | ||
* Elasticsearch Docker base image: oss distribution under Apache2 license | ||
*/ | ||
public static final DockerImageName ELASTICSEARCH_OSS_IMAGE = DockerImageName.parse("docker.elastic.co/elasticsearch/elasticsearch-oss"); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This image has been removed after 7.10.2. So I believe that I should update the PR and remove entirely this field.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Aren't images distributed over Docker Hub again?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nope. There's no -oss package after 7.10.2
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
But there's the default distribution as it has always been 😊
Thanks for the PR @dadoonet ! Our current approach is not to make public those fields public. However, we have noticed an improvement in our documentation due to not all modules expose the image to be used. |
It's probably better to use the same way to declare an image as we have with other modules like couchbase for example.
It has also a positive "side" effect to highlight the fact that it's a good practice to set the tag when building the container.