Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Doc update for elasticsearch and kafka #2615

Merged
merged 3 commits into from
May 2, 2020
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion docs/modules/elasticsearch.md
Original file line number Diff line number Diff line change
Expand Up @@ -36,7 +36,7 @@ container.stop();
```

Note that if you are still using the [TransportClient](https://www.elastic.co/guide/en/elasticsearch/client/java-api/6.3/transport-client.html)
(not recommended as deprecated), the default cluster name is set to `docker-cluster` so you need to change `cluster.name` setting
(not recommended as it is deprecated), the default cluster name is set to `docker-cluster` so you need to change `cluster.name` setting
or set `client.transport.ignore_cluster_name` to `true`.

## Choose your Elasticsearch license
Expand Down
2 changes: 1 addition & 1 deletion docs/modules/kafka.md
Original file line number Diff line number Diff line change
Expand Up @@ -42,7 +42,7 @@ new KafkaContainer().withExternalZookeeper("localhost:2181")

If your test needs to run some other Docker container which needs access to the Kafka, do the following:

* Run you other container on the same network as Kafka container. E.g. as following:
* Run your other container on the same network as Kafka container, e.g.,
rnorth marked this conversation as resolved.
Show resolved Hide resolved
```java
new GenericContainer("myImage").withNetwork(kafka.getNetwork())
```
Expand Down