Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix internal port check when other ports are opened as well on the target container #2363

Merged
merged 9 commits into from Mar 10, 2020
Merged

Fix internal port check when other ports are opened as well on the target container #2363

merged 9 commits into from Mar 10, 2020

Commits on Feb 24, 2020

  1. Remove redundant execCreateCmd call 

    This one is never used and probably causes some garbage on the docker side.
    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    b6c1b7f View commit details
    Browse the repository at this point in the history

  2. Allow leading zeros in /proc/net/tcp* when doing internal port listen… 

    … check

When at least one process is listening for a port that is significantly
higher then the port we're checking, this check will fail as the checked
port will contain leading zeros in the output of "cat /proc/net/tcp".

This commit fixes this by changing the grep to ":0*XXX".
    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    1c7aeee View commit details
    Browse the repository at this point in the history

  3. Surround grep parameter with ' 

    Otherwise unnecessary shell expansion is tried
    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    0ace0eb View commit details
    Browse the repository at this point in the history

  4. Refactor/Rewrite InternalCommandPortListeningCheckTest to test all po… 

    …ssible checks

This commit refactors InternalCommandPortListeningCheckTest to work with
3 different nginx based containers, each being able to only succeed one of
the 3 tests performed in InternalCommandPortListeningCheck. Each test is
now executed agains all 3 containers to ensure that all tests work as
expected.
    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    d22fa3e View commit details
    Browse the repository at this point in the history

  5. Add test for low+high ports 

    This test should fail without the leading zeros fix found a few commits
before this one.
    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    ee4e92c View commit details
    Browse the repository at this point in the history

  6. Check for bash existence instead of only mentioning it in a comment

    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    365a9b0 View commit details
    Browse the repository at this point in the history

  7. Rename nginx_on_8080.conf to nginx.conf 

    It's not only port 8080 anymore, so better not have it in the name.
    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    885df86 View commit details
    Browse the repository at this point in the history

  8. Make container a @rule again by moving initialization into contructor

    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    4df12fc View commit details
    Browse the repository at this point in the history

  9. Wait a few seconds for InternalCommandPortListeningCheck to pass

    @codablock
    codablock committed Feb 24, 2020
    Configuration menu
    Copy the full SHA
    df6c38a View commit details
    Browse the repository at this point in the history