Fix Couchbase FTS support #2350
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bsideup
requested changes
Feb 12, 2020
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseServiceWaitStrategy.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Feb 12, 2020
modules/couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseQueryWaitStrategy.java
Outdated
Show resolved
Hide resolved
|
Hello! When do you think this will be merged and delivered? I need this in order to add FTS compatibility to Couchmove |
|
I don't understand why checks are failing, the test are ok locally, and the ones that are failing doesn't have any relation with my updates. Can someone take a look into that ? |
This was referenced Feb 25, 2020
|
@bsideup @rnorth @kiview Can you please help on this ? It's small improvements and it is blocking both tchlyah/couchmove#5 and jhipster/generator-jhipster#11421! |
bsideup
reviewed
Mar 13, 2020
.../couchbase/src/main/java/org/testcontainers/couchbase/CouchbaseQueryServiceWaitStrategy.java
Outdated
Show resolved
Hide resolved
bsideup
reviewed
Mar 13, 2020
modules/couchbase/src/test/java/org/testcontainers/couchbase/Couchbase6_0Test.java
Outdated
Show resolved
Hide resolved
1 task
|
Is there still any blocking issue here? |
|
I don't understand why this is still open, it is small fix and blocking 2 PR! Can you please take a look ? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fts_adminuser role