Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

JDBC: Fix parsing empty connection parameters #2207

Merged
merged 1 commit into from Dec 27, 2019
Merged

JDBC: Fix parsing empty connection parameters #2207

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Jump to
Jump to file
Failed to load files.
Diff view
Diff view
2 changes: 1 addition & 1 deletion modules/jdbc/src/main/java/org/testcontainers/jdbc/ConnectionUrl.java
View file
Open in desktop
Expand Up @@ -228,7 +228,7 @@ public interface Patterns {

Pattern TC_PARAM_MATCHING_PATTERN = Pattern.compile(TC_PARAM_NAME_PATTERN + "=([^\\?&]+)");

Pattern QUERY_PARAM_MATCHING_PATTERN = Pattern.compile("([^\\?&=]+)=([^\\?&]+)");
Pattern QUERY_PARAM_MATCHING_PATTERN = Pattern.compile("([^\\?&=]+)=([^\\?&]*)");

}

Expand Down
6 changes: 6 additions & 0 deletions modules/jdbc/src/test/java/org/testcontainers/jdbc/ConnectionUrlTest.java
View file
Open in desktop
Expand Up @@ -49,6 +49,12 @@ public void testConnectionUrl2() {

}

@Test
public void testEmptyQueryParameter() {
ConnectionUrl url = ConnectionUrl.newInstance("jdbc:tc:mysql://somehostname/databasename?key=");
assertEquals("'key' property value", "", url.getQueryParameters().get("key"));
}

@Test
public void testTmpfsOption() {
String urlString = "jdbc:tc:mysql://somehostname/databasename?TC_TMPFS=key:value,key1:value1";
Expand Down